From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45344 invoked by alias); 2 Dec 2015 13:19:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 45325 invoked by uid 89); 2 Dec 2015 13:19:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e06smtp05.uk.ibm.com Received: from e06smtp05.uk.ibm.com (HELO e06smtp05.uk.ibm.com) (195.75.94.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 02 Dec 2015 13:19:03 +0000 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Dec 2015 13:18:58 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 2 Dec 2015 13:18:56 -0000 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: krebbel@linux.vnet.ibm.com X-IBM-RcptTo: gcc-patches@gcc.gnu.org Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6ECC62190066 for ; Wed, 2 Dec 2015 13:18:48 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tB2DItgq2687356 for ; Wed, 2 Dec 2015 13:18:55 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tB2DIsYH027795 for ; Wed, 2 Dec 2015 06:18:55 -0700 Received: from [9.152.212.123] (dyn-9-152-212-123.boeblingen.de.ibm.com [9.152.212.123]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id tB2DIs2B027785; Wed, 2 Dec 2015 06:18:54 -0700 Subject: Re: S/390: Fix warnings in "*setmem_long..." patterns. To: Ulrich Weigand References: <20151202125141.9BF6CF8BB@oc7340732750.ibm.com> <565EEE13.3010405@linux.vnet.ibm.com> Cc: gcc-patches@gcc.gnu.org, vogt@linux.vnet.ibm.com From: Andreas Krebbel Message-ID: <565EEFBE.3090103@linux.vnet.ibm.com> Date: Wed, 02 Dec 2015 13:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <565EEE13.3010405@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15120213-0021-0000-0000-00000505554C X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00252.txt.bz2 On 12/02/2015 02:11 PM, Andreas Krebbel wrote: > On 12/02/2015 01:51 PM, Ulrich Weigand wrote: >> Andreas Krebbel wrote: >>> On 12/02/2015 11:12 AM, Dominik Vogt wrote: >>>> Hopefully, this is correct now; it does pass the functional test case >>>> that's part of the patch. Unfortunately the define_insn patters >>>> had to be duplicated because of the new subreg offsets. >>> >>> The number of patterns could possibly be reduced using the define_subst machinery. I'm looking into >>> this for some other changes. No need to do this right now. We can do this later on-top. >> >> For this particular issue, shouldn't a simple mode_attr be OK? >> I see that the sh port uses this: >> >> (define_mode_attr lowpart_be [(QI "3") (HI "2")]) >> >> [(set (reg:SI T_REG) >> (eq:SI >> (subreg:QIHI >> (and:SI (match_operand:SI 0 "arith_reg_operand") >> (match_operand:SI 1 "arith_reg_operand")) ) >> (const_int 0)))] > > Unfortunately in our case the attribute value doesn't only depend on the mode. It also depends on > zarch/esa. We would need some kind of conditional attribute. However, we could probably at least merge the two zarch variants. The define_subst is probably the right thing for adding the AND around the padding byte operand. Bye, -Andreas-