* [PING^2][PATCH] Improve C++ loop's backward-jump location
@ 2015-11-24 14:58 Andreas Arnez
2015-11-25 22:12 ` Jason Merrill
2015-12-02 13:53 ` Alan Lawrence
0 siblings, 2 replies; 4+ messages in thread
From: Andreas Arnez @ 2015-11-24 14:58 UTC (permalink / raw)
To: gcc-patches; +Cc: Jeff Law, Bernd Schmidt, Jason Merrill, Nathan Sidwell
Ping?
https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01192.html
I guess we want C and C++ behave the same here?
> gcc/cp/ChangeLog:
>
> * cp-gimplify.c (genericize_cp_loop): Change LOOP_EXPR's location
> to start of loop body instead of start of loop.
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/guality/pr67192.C: New test.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PING^2][PATCH] Improve C++ loop's backward-jump location 2015-11-24 14:58 [PING^2][PATCH] Improve C++ loop's backward-jump location Andreas Arnez @ 2015-11-25 22:12 ` Jason Merrill 2015-12-02 13:53 ` Alan Lawrence 1 sibling, 0 replies; 4+ messages in thread From: Jason Merrill @ 2015-11-25 22:12 UTC (permalink / raw) To: Andreas Arnez, gcc-patches; +Cc: Jeff Law, Bernd Schmidt, Nathan Sidwell OK. Jason ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PING^2][PATCH] Improve C++ loop's backward-jump location 2015-11-24 14:58 [PING^2][PATCH] Improve C++ loop's backward-jump location Andreas Arnez 2015-11-25 22:12 ` Jason Merrill @ 2015-12-02 13:53 ` Alan Lawrence 2015-12-02 14:44 ` Andreas Arnez 1 sibling, 1 reply; 4+ messages in thread From: Alan Lawrence @ 2015-12-02 13:53 UTC (permalink / raw) To: Andreas Arnez, gcc-patches Cc: Jeff Law, Bernd Schmidt, Jason Merrill, Nathan Sidwell On 24/11/15 14:55, Andreas Arnez wrote: > Ping? > > https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01192.html > > I guess we want C and C++ behave the same here? > >> gcc/cp/ChangeLog: >> >> * cp-gimplify.c (genericize_cp_loop): Change LOOP_EXPR's location >> to start of loop body instead of start of loop. >> >> gcc/testsuite/ChangeLog: >> >> * g++.dg/guality/pr67192.C: New test. > > > Since this, we've been seeing these tests fail natively on AArch64 and ARM: FAIL: g++.dg/gcov/gcov-1.C -std=gnu++11 gcov: 3 failures in line counts, 0 in branch percentages, 0 in return percentages, 0 in intermediate format FAIL: g++.dg/gcov/gcov-1.C -std=gnu++11 line 115: is 27:should be 14 FAIL: g++.dg/gcov/gcov-1.C -std=gnu++11 line 58: is 18:should be 9 FAIL: g++.dg/gcov/gcov-1.C -std=gnu++11 line 73: is 162:should be 81 FAIL: g++.dg/gcov/gcov-1.C -std=gnu++14 gcov: 3 failures in line counts, 0 in branch percentages, 0 in return percentages, 0 in intermediate format FAIL: g++.dg/gcov/gcov-1.C -std=gnu++14 line 115: is 27:should be 14 FAIL: g++.dg/gcov/gcov-1.C -std=gnu++14 line 58: is 18:should be 9 FAIL: g++.dg/gcov/gcov-1.C -std=gnu++14 line 73: is 162:should be 81 FAIL: g++.dg/gcov/gcov-1.C -std=gnu++98 gcov: 3 failures in line counts, 0 in branch percentages, 0 in return percentages, 0 in intermediate format FAIL: g++.dg/gcov/gcov-1.C -std=gnu++98 line 115: is 27:should be 14 FAIL: g++.dg/gcov/gcov-1.C -std=gnu++98 line 58: is 18:should be 9 FAIL: g++.dg/gcov/gcov-1.C -std=gnu++98 line 73: is 162:should be 81 I've not had a chance to look any further yet. Thanks, Alan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PING^2][PATCH] Improve C++ loop's backward-jump location 2015-12-02 13:53 ` Alan Lawrence @ 2015-12-02 14:44 ` Andreas Arnez 0 siblings, 0 replies; 4+ messages in thread From: Andreas Arnez @ 2015-12-02 14:44 UTC (permalink / raw) To: Alan Lawrence Cc: gcc-patches, Jeff Law, Bernd Schmidt, Jason Merrill, Nathan Sidwell On Wed, Dec 02 2015, Alan Lawrence wrote: [...] > Since this, we've been seeing these tests fail natively on AArch64 and ARM: > > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++11 gcov: 3 failures in line > counts, 0 in branch percentages, 0 in return percentages, 0 in > intermediate format > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++11 line 115: is 27:should be 14 > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++11 line 58: is 18:should be 9 > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++11 line 73: is 162:should be 81 > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++14 gcov: 3 failures in line > counts, 0 in branch percentages, 0 in return percentages, 0 in > intermediate format > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++14 line 115: is 27:should be 14 > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++14 line 58: is 18:should be 9 > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++14 line 73: is 162:should be 81 > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++98 gcov: 3 failures in line > counts, 0 in branch percentages, 0 in return percentages, 0 in > intermediate format > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++98 line 115: is 27:should be 14 > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++98 line 58: is 18:should be 9 > FAIL: g++.dg/gcov/gcov-1.C -std=gnu++98 line 73: is 162:should be 81 Right, sorry about that. See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68603 This should be fixed now. Let me know if you still see problems. -- Andreas ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-02 14:44 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-11-24 14:58 [PING^2][PATCH] Improve C++ loop's backward-jump location Andreas Arnez 2015-11-25 22:12 ` Jason Merrill 2015-12-02 13:53 ` Alan Lawrence 2015-12-02 14:44 ` Andreas Arnez
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).