From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106459 invoked by alias); 2 Dec 2015 19:54:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 106440 invoked by uid 89); 2 Dec 2015 19:54:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Dec 2015 19:54:52 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1a4DUG-0007F2-UO from Cesar_Philippidis@mentor.com ; Wed, 02 Dec 2015 11:54:48 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.224.2; Wed, 2 Dec 2015 11:54:48 -0800 Subject: Re: [OpenACC 0/7] host_data construct To: Jakub Jelinek References: <20151026183422.GW478@tucnak.redhat.com> <20151102183339.365c3d33@octopus> <20151112111621.657650bc@octopus> <20151118124747.30a2ec5d@octopus> <20151119131345.GX5675@tucnak.redhat.com> <20151119142650.5a8842e4@octopus> <20151119155723.GA5675@tucnak.redhat.com> <20151130193034.71143aa4@octopus> <877fkwn8p6.fsf@kepler.schwinge.homeip.net> <565F437A.6090103@codesourcery.com> <20151202193502.GY5675@tucnak.redhat.com> CC: Thomas Schwinge , Julian Brown , GCC Patches , James Norris , "Joseph S. Myers" , Nathan Sidwell , Fortran List From: Cesar Philippidis Message-ID: <565F4C88.3050707@codesourcery.com> Date: Wed, 02 Dec 2015 19:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151202193502.GY5675@tucnak.redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00360.txt.bz2 On 12/02/2015 11:35 AM, Jakub Jelinek wrote: > On Wed, Dec 02, 2015 at 11:16:10AM -0800, Cesar Philippidis wrote: >>> --- gcc/testsuite/gfortran.dg/goacc/coarray_2.f90 >>> +++ gcc/testsuite/gfortran.dg/goacc/coarray_2.f90 >>> @@ -3,6 +3,7 @@ >>> ! >>> ! PR fortran/63861 >>> ! { dg-xfail-if "" { *-*-* } } >>> +! { dg-excess-errors "TODO" } >> >> This host_data patch exposed a bug in the fortran front end where it was >> allowing arrays to be used as reduction variables. If replace you >> replace codimension with dimension, you'd see a similar ICE. The >> attached patch, while it doesn't make any attempt to fix the gimplifier >> changes, does teach the fortran front end to error on acc reductions >> containing array variables. > > Does the OpenACC standard disallow array reductions? > Just asking, because OpenMP allows them (up to 4.0 only in Fortran, > in 4.5 also C/C++ array sections are allowed). > > If the OpenACC standard disallows them, then it is desirable to reject them > and the patch is ok, otherwise you should try harder to support them ;). Array reductions aren't supported in OpenACC 2.0. Cesar