public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom de Vries <Tom_deVries@mentor.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
	"gcc-patches@gnu.org"	<gcc-patches@gnu.org>,
	Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta
Date: Thu, 03 Dec 2015 00:27:00 -0000	[thread overview]
Message-ID: <565F8C69.1070906@mentor.com> (raw)
In-Reply-To: <565F8881.90609@mentor.com>

On 03/12/15 01:10, Tom de Vries wrote:
>
> I've managed to reproduce it. The difference between pass and fail is
> whether the compiler is configured with or without accelerator.
>
> I'll look into it.

In the configuration with accelerator, the flag node->force_output is on 
for foo._omp.fn.

This causes nonlocal_p to be true in ipa_pta_execute, which causes the 
optimization to fail.

The flag is decribed as:
...
   /* The symbol will be assumed to be used in an invisible way (like
      by an toplevel asm statement).  */
  ...

Looks like I have to ignore the force_output flag as well in 
ipa_pta_execute for this sort of node.

Thanks,
- Tom

  reply	other threads:[~2015-12-03  0:27 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30  9:00 [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL " Tom de Vries
2015-11-30  9:36 ` Richard Biener
2015-11-30 12:20   ` Tom de Vries
2015-11-30 13:32     ` Richard Biener
2015-11-30 13:35       ` Jakub Jelinek
2015-12-03 11:49         ` Tom de Vries
2015-11-30 16:44       ` Tom de Vries
2015-11-30 16:52         ` Jakub Jelinek
2015-11-30 18:00           ` Tom de Vries
2015-12-01 12:27             ` Christophe Lyon
2015-12-01 12:30               ` Jakub Jelinek
2015-12-01 14:49                 ` Tom de Vries
2015-12-01 14:27         ` [PATCH] Handle BUILT_IN_GOACC_PARALLEL " Tom de Vries
2015-12-01 14:38           ` Richard Biener
2015-12-01 14:44           ` Jakub Jelinek
2015-12-01 23:48             ` Tom de Vries
2015-12-02  9:31               ` Jakub Jelinek
2015-12-02 17:58           ` Thomas Schwinge
2015-12-02 23:32             ` Tom de Vries
2015-12-03  0:10               ` Tom de Vries
2015-12-03  0:27                 ` Tom de Vries [this message]
2015-12-03  8:59                   ` Richard Biener
2015-12-03 11:09                     ` Tom de Vries
2015-12-03 11:13                       ` Richard Biener
2015-12-03 11:13                       ` Jakub Jelinek
2015-12-10 13:15                       ` Tom de Vries
2015-12-16 16:02                         ` Tom de Vries
2016-01-05 14:56                           ` [PING][PATCH] Mark symbols in offload tables with force_output in read_offload_tables Tom de Vries
2016-01-25 13:27                             ` Ilya Verbin
2016-01-26 12:22                               ` Tom de Vries
2016-01-26 13:02                                 ` Ilya Verbin
2016-02-08 13:20                                   ` Tom de Vries
2016-02-08 15:02                                     ` Ilya Verbin
2016-02-15  7:38                                     ` [PING][PATCH] Don't mark offload symbols with force_output in ltrans Tom de Vries
2016-02-15  9:07                                       ` Richard Biener
2016-01-26 14:13                                 ` [PING][PATCH] Mark symbols in offload tables with force_output in read_offload_tables Richard Biener
2016-01-08  8:17                           ` [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta Richard Biener
2016-01-14  9:31                             ` Thomas Schwinge
2016-01-14  9:32                               ` Richard Biener
2015-12-09 10:01     ` [PATCH, PR68716] Fix GOMP/GOACC_parallel handling in find_func_clobbers Tom de Vries
2015-12-09 10:04       ` Jakub Jelinek
2015-12-09 10:09         ` Richard Biener
2015-12-09 10:11         ` Tom de Vries
2015-12-10  9:01       ` [committed, obvious] Remove invalid assert in find_func_aliases_for_builtin_call Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565F8C69.1070906@mentor.com \
    --to=tom_devries@mentor.com \
    --cc=gcc-patches@gnu.org \
    --cc=jakub@redhat.com \
    --cc=rguenther@suse.de \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).