From: Tom de Vries <Tom_deVries@mentor.com>
To: Sebastian Pop <s.pop@samsung.com>, <sebpop@gmail.com>
Cc: <richard.guenther@gmail.com>, <gcc-patches@gcc.gnu.org>,
<hiraditya@msn.com>
Subject: Fix buildbreaker with isl 0.14
Date: Thu, 03 Dec 2015 08:49:00 -0000 [thread overview]
Message-ID: <5660020E.6080805@mentor.com> (raw)
In-Reply-To: <565F8516.4070406@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]
[ was: Re: [PATCH] [graphite] handle missing isl_ast_expr ]
On 03/12/15 00:56, Tom de Vries wrote:
> Hi,
>
> This break the build for me, with isl 0.14.
>
> ...
> src/gcc/graphite-isl-ast-to-gimple.c: In member function ‘tree_node*
> translate_isl_ast_to_gimple::binary_op_to_tree(tree, isl_ast_expr*,
> ivs_params&)Â’:
> src/gcc/graphite-isl-ast-to-gimple.c:591:10: error: ‘isl_ast_op_zdiv_r’
> was not declared in this scope
> case isl_ast_op_zdiv_r:
> ^
> ...
>
> Thanks,
> - Tom
>
> On 02/12/15 23:17, Sebastian Pop wrote:
>> From ISL's documentation, isl_ast_op_zdiv_r is equal to zero iff the
>> remainder
>> on integer division is zero. Code generate a modulo operation for that.
>>
>> * graphite-isl-ast-to-gimple.c (binary_op_to_tree): Handle
>> isl_ast_op_zdiv_r.
>> (gcc_expression_from_isl_expr_op): Same.
>>
>> * gcc.dg/graphite/id-28.c: New.
this patch fixes the build breaker with isl 0.14 for me. I'm using the
HAVE_ISL_OPTIONS_SET_SCHEDULE_SERIALIZE_SCCS macro (which is set for isl
0.15, and not before) to guard the code handling isl_ast_op_zdiv_r
(which I suppose is new in isl 0.15).
OK for trunk?
Thanks,
- Tom
[-- Attachment #2: 0001-Guard-isl_ast_op_zdiv_r-usage-with-HAVE_ISL_OPTIONS_SET_SCHEDULE_SERIALIZE_SCCS.patch --]
[-- Type: text/x-patch, Size: 1338 bytes --]
Guard isl_ast_op_zdiv_r usage with HAVE_ISL_OPTIONS_SET_SCHEDULE_SERIALIZE_SCCS
2015-12-03 Tom de Vries <tom@codesourcery.com>
* graphite-isl-ast-to-gimple.c (binary_op_to_tree)
(gcc_expression_from_isl_expr_op): Guard isl_ast_op_zdiv_r usage with
HAVE_ISL_OPTIONS_SET_SCHEDULE_SERIALIZE_SCCS.
---
gcc/graphite-isl-ast-to-gimple.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gcc/graphite-isl-ast-to-gimple.c b/gcc/graphite-isl-ast-to-gimple.c
index 06a2062..20eb80f 100644
--- a/gcc/graphite-isl-ast-to-gimple.c
+++ b/gcc/graphite-isl-ast-to-gimple.c
@@ -588,7 +588,9 @@ binary_op_to_tree (tree type, __isl_take isl_ast_expr *expr, ivs_params &ip)
}
return fold_build2 (TRUNC_DIV_EXPR, type, tree_lhs_expr, tree_rhs_expr);
+#if HAVE_ISL_OPTIONS_SET_SCHEDULE_SERIALIZE_SCCS
case isl_ast_op_zdiv_r:
+#endif
case isl_ast_op_pdiv_r:
/* As ISL operates on arbitrary precision numbers, we may end up with
division by 2^64 that is folded to 0. */
@@ -759,7 +761,9 @@ gcc_expression_from_isl_expr_op (tree type, __isl_take isl_ast_expr *expr,
case isl_ast_op_pdiv_q:
case isl_ast_op_pdiv_r:
case isl_ast_op_fdiv_q:
+#if HAVE_ISL_OPTIONS_SET_SCHEDULE_SERIALIZE_SCCS
case isl_ast_op_zdiv_r:
+#endif
case isl_ast_op_and:
case isl_ast_op_or:
case isl_ast_op_eq:
next prev parent reply other threads:[~2015-12-03 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 22:17 [PATCH] [graphite] handle missing isl_ast_expr Sebastian Pop
2015-12-02 23:56 ` Tom de Vries
2015-12-03 8:49 ` Tom de Vries [this message]
2015-12-03 10:04 ` Fix buildbreaker with isl 0.14 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5660020E.6080805@mentor.com \
--to=tom_devries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hiraditya@msn.com \
--cc=richard.guenther@gmail.com \
--cc=s.pop@samsung.com \
--cc=sebpop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).