[ was: Re: [PATCH] [graphite] handle missing isl_ast_expr ] On 03/12/15 00:56, Tom de Vries wrote: > Hi, > > This break the build for me, with isl 0.14. > > ... > src/gcc/graphite-isl-ast-to-gimple.c: In member function ‘tree_node* > translate_isl_ast_to_gimple::binary_op_to_tree(tree, isl_ast_expr*, > ivs_params&)’: > src/gcc/graphite-isl-ast-to-gimple.c:591:10: error: ‘isl_ast_op_zdiv_r’ > was not declared in this scope > case isl_ast_op_zdiv_r: > ^ > ... > > Thanks, > - Tom > > On 02/12/15 23:17, Sebastian Pop wrote: >> From ISL's documentation, isl_ast_op_zdiv_r is equal to zero iff the >> remainder >> on integer division is zero. Code generate a modulo operation for that. >> >> * graphite-isl-ast-to-gimple.c (binary_op_to_tree): Handle >> isl_ast_op_zdiv_r. >> (gcc_expression_from_isl_expr_op): Same. >> >> * gcc.dg/graphite/id-28.c: New. this patch fixes the build breaker with isl 0.14 for me. I'm using the HAVE_ISL_OPTIONS_SET_SCHEDULE_SERIALIZE_SCCS macro (which is set for isl 0.15, and not before) to guard the code handling isl_ast_op_zdiv_r (which I suppose is new in isl 0.15). OK for trunk? Thanks, - Tom