Re: [PATCH,RFC] Introduce RUN_UNDER_VALGRIND in test-suite

[Bernd Schmidt <bschmidt@redhat.com>]

On 11/23/2015 10:34 AM, Martin Liška wrote:
> On 11/21/2015 05:26 AM, Hans-Peter Nilsson wrote:
>> IIRC you can replace the actual dg-runtest proc with your own
>> (implementing a wrapper).  Grep aroung, I think we do that
>> already.  That's certainly preferable instead of touching all
>> callers.
>
> You are right, the suggested patch was over-kill, wrapper should be fine for that.
> Currently I've been playing with a bit different approach (suggested by Markus),
> where I would like to enable valgrind in gcc.c using an environmental variable.
>
> Question is if it should replace existing ENABLE_VALGRIND_CHECKING and how to
> integrate it with a valgrind suppressions file?

This patch still seems to be in the queue. I've been looking at it every 
now and then, without really forming an opinion. In any case, I think 
we'll need to postpone this to stage1 at this point.

Wouldn't it be better to fix issues first and only then enable running 
the testsuite with valgrind, rather than make a suppression file?

Your latest patch seems to add the option of running the compiler 
without ENABLE_CHECKING_VALGRIND being defined. Doesn't this run into 
problems when the support in ggc isn't compiled in?


Bernd