From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80001 invoked by alias); 4 Dec 2015 18:45:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 79960 invoked by uid 89); 4 Dec 2015 18:45:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 04 Dec 2015 18:45:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 464A58E37C; Fri, 4 Dec 2015 18:44:58 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-91.phx2.redhat.com [10.3.113.91]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB4Iiv9G014691; Fri, 4 Dec 2015 13:44:58 -0500 Subject: Re: [PATCH] Fix declaration of pthread-structs in s-osinte-rtems.ads (ada/68169) To: Jan Sommer , gcc-patches@gcc.gnu.org References: <3667951.xxJfb3I2z2@kubuntu> <565E9A4E.6070101@redhat.com> <1838497.lGhAiFNhbp@kubuntu> Cc: Joel Sherrill , "devel@rtems.org" , "sebastian.huber@embedded-brains.de" From: Jeff Law Message-ID: <5661DF29.8010508@redhat.com> Date: Fri, 04 Dec 2015 18:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1838497.lGhAiFNhbp@kubuntu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00622.txt.bz2 On 12/02/2015 03:23 PM, Jan Sommer wrote: > Am Wednesday 02 December 2015, 08:13:20 schrieb Joel Sherrill: >> >> On December 2, 2015 2:14:22 AM EST, Jeff Law >> wrote: >>> On 12/01/2015 12:56 PM, Jan Sommer wrote: >>>> Am Monday 30 November 2015, 16:19:30 schrieb Jeff Law: >>>>> On 11/30/2015 03:06 PM, Jan Sommer wrote: >>>>>> Could someone with write access please commit the patch? >>>>>> The paperwork with the FSF has gone through. If something >>>>>> else is >>> missing, please tell me. >>>>>> I won't be available next week. >>>>> I'm not sure what you built your patches again, but I can't >>>>> apply >>> them >>>>> to the trunk. Can you resend a patch as a diff against the >>>>> trunk. >>>>> >>>>> Often I can fix things by hand, but this is Ada and I'd be >>>>> much more likely to botch something. >>>> >>>> I updated the patches again. They should now fit with the heads >>>> of >>> the respective branches again. >>>> Maybe the Changelog will be out of synch again. The patches are >>>> for the following branches: ada-68169_4.9.diff --> >>>> gcc-4_9-branch ada-68169_5.x.diff --> gcc-5-branch >>>> ada-68169_trunk.diff --> trunk >>>> >>>> Let me know if they apply this time. I used svn diff to create >>>> them >>> and used patch -p0 to test if they apply locally. THanks. I've >>> committed this to the trunk based on Joel's comments. >>> >>> The gcc-5 branch is frozen for the upcoming release and gcc-4.9 >>> is regression/doc fixes only. It'll be up to the release >>> managers whether >>> >>> or not to backport to those branches. >> >> Thanks Jeff. >> >> I would consider this a regression. RTEMS changed the >> pthread_attr_t when we added thread affinity and updating Ada to >> match slipped through. We knew it needed attention for SMP but >> missed this critical piece to keep it working. OK. I wasn't aware of this. Given this note, I went ahead and committed the change to the gcc-5 and gcc-4.9 branches. However, it missed the deadline for 5.3, which went out earlier this morning. Jeff