public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Re: [PATCH 1/6] [DJGPP] libstdc++-v3/config/os/djgpp/error_constants.h: Update according to errno codes available for DJGPP
       [not found] <56631268.2020109@iki.fi>
@ 2015-12-05 18:36 ` Andris Pavenis
  2015-12-10 22:34   ` Jeff Law
  0 siblings, 1 reply; 4+ messages in thread
From: Andris Pavenis @ 2015-12-05 18:36 UTC (permalink / raw)
  To: gcc-patches, dj, libstdc++

On 12/05/2015 06:35 PM, Andris Pavenis wrote:
> Included patch updates libstdc++-v3/config/os/djgpp/error_constants.h
> according to defines available in DJGPP errno.h.
>
> I'm reposting a patch as earlier post (Nov 15, 2015) have bug in changelog entry
>
> Andris
>
> 2015-12-05 Andris Pavenis <andris.pavenis@iki.fi>
>
> * config/os/djgpp/error_constants.h: update according to DJGPP errno macros.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/6] [DJGPP] libstdc++-v3/config/os/djgpp/error_constants.h: Update according to errno codes available for DJGPP
  2015-12-05 18:36 ` [PATCH 1/6] [DJGPP] libstdc++-v3/config/os/djgpp/error_constants.h: Update according to errno codes available for DJGPP Andris Pavenis
@ 2015-12-10 22:34   ` Jeff Law
  2015-12-10 22:58     ` DJ Delorie
  0 siblings, 1 reply; 4+ messages in thread
From: Jeff Law @ 2015-12-10 22:34 UTC (permalink / raw)
  To: Andris Pavenis, gcc-patches, dj, libstdc++

On 12/05/2015 11:36 AM, Andris Pavenis wrote:
> On 12/05/2015 06:35 PM, Andris Pavenis wrote:
>> Included patch updates libstdc++-v3/config/os/djgpp/error_constants.h
>> according to defines available in DJGPP errno.h.
>>
>> I'm reposting a patch as earlier post (Nov 15, 2015) have bug in
>> changelog entry
>>
>> Andris
>>
>> 2015-12-05 Andris Pavenis <andris.pavenis@iki.fi>
>>
>> * config/os/djgpp/error_constants.h: update according to DJGPP errno
>> macros.
I can't really judge this one.  Either DJ or Jon would need to some in 
on this.

Jeff

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/6] [DJGPP] libstdc++-v3/config/os/djgpp/error_constants.h: Update according to errno codes available for DJGPP
  2015-12-10 22:34   ` Jeff Law
@ 2015-12-10 22:58     ` DJ Delorie
  2015-12-11 11:59       ` Jonathan Wakely
  0 siblings, 1 reply; 4+ messages in thread
From: DJ Delorie @ 2015-12-10 22:58 UTC (permalink / raw)
  To: Jeff Law; +Cc: andris.pavenis, gcc-patches, libstdc++


> I can't really judge this one.  Either DJ or Jon would need to some in 
> on this.

Looks OK to me, although in the default configuration (plain DJGPP)
the #ifdefs will always be false (omitted), which is harmless.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/6] [DJGPP] libstdc++-v3/config/os/djgpp/error_constants.h: Update according to errno codes available for DJGPP
  2015-12-10 22:58     ` DJ Delorie
@ 2015-12-11 11:59       ` Jonathan Wakely
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Wakely @ 2015-12-11 11:59 UTC (permalink / raw)
  To: DJ Delorie; +Cc: Jeff Law, andris.pavenis, gcc-patches, libstdc++

On 10/12/15 17:58 -0500, DJ Delorie wrote:
>
>> I can't really judge this one.  Either DJ or Jon would need to some in
>> on this.
>
>Looks OK to me, although in the default configuration (plain DJGPP)
>the #ifdefs will always be false (omitted), which is harmless.

Is there a non-default configuration where they are true?

I've been wavering on approving this patch, not because there's
anything wrong with it, but because I'm still ruminating on
https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01458.html

I think I'm going to make that change for mingw-w64, but either way
the DJGPP patch is OK for trunk (assuming there is some non-default
configuration where it actually does something useful).

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-12-11 11:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <56631268.2020109@iki.fi>
2015-12-05 18:36 ` [PATCH 1/6] [DJGPP] libstdc++-v3/config/os/djgpp/error_constants.h: Update according to errno codes available for DJGPP Andris Pavenis
2015-12-10 22:34   ` Jeff Law
2015-12-10 22:58     ` DJ Delorie
2015-12-11 11:59       ` Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).