From: Bernd Schmidt <bschmidt@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "Manuel López-Ibáñez" <lopezibanez@gmail.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
"Gcc Patch List" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix -Werror= handling for Joined warnings, add a few missing Warning keywords (PRs c/48088, c/68657)
Date: Mon, 07 Dec 2015 15:11:00 -0000 [thread overview]
Message-ID: <5665A1B4.1090905@redhat.com> (raw)
In-Reply-To: <20151207134448.GY5675@tucnak.redhat.com>
On 12/07/2015 02:44 PM, Jakub Jelinek wrote:
>
> So like this?
> +/* Perform diagnostics for read_cmdline_option and control_warning_option
> + functions. Returns true if an error has been diagnosed. */
Let's document arguments; for the ones identical to read_cmdline_option
an explicit pointer there is sufficient, but errors is new.
> @@ -1332,8 +1348,8 @@ get_option_state (struct gcc_options *op
> used by -Werror= and #pragma GCC diagnostic. */
>
> void
> -control_warning_option (unsigned int opt_index, int kind, bool imply,
> - location_t loc, unsigned int lang_mask,
> +control_warning_option (unsigned int opt_index, int kind, const char *arg,
> + bool imply, location_t loc, unsigned int lang_mask,
This also needs an update to the function comment.
Other than that I'm ok with this. This area could probably be
restructured a bit but for now I think this is good enough.
Bernd
next prev parent reply other threads:[~2015-12-07 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 16:37 Jakub Jelinek
2015-12-04 17:02 ` Bernd Schmidt
2015-12-04 17:53 ` Jakub Jelinek
2015-12-04 18:20 ` Manuel López-Ibáñez
2015-12-04 19:37 ` Jakub Jelinek
2015-12-07 10:24 ` Bernd Schmidt
2015-12-07 13:45 ` Jakub Jelinek
2015-12-07 15:11 ` Bernd Schmidt [this message]
2015-12-07 22:42 ` Jakub Jelinek
2015-12-08 11:56 ` Bernd Schmidt
2015-12-11 20:18 ` [PATCH] Fix -Werror= handling with aliases (PR c/68833) Jakub Jelinek
2015-12-14 16:22 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5665A1B4.1090905@redhat.com \
--to=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=lopezibanez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).