From: Bernd Schmidt <bschmidt@redhat.com>
To: Steve Ellcey <sellcey@imgtec.com>, gcc-patches@gcc.gnu.org
Subject: Re: [Patch] Fix bug for frame instructions in annulled delay slots
Date: Mon, 07 Dec 2015 19:28:00 -0000 [thread overview]
Message-ID: <5665DDCB.5070003@redhat.com> (raw)
In-Reply-To: <b03b5863-934a-4ca7-a0bf-126e82d34c6b@BAMAIL02.ba.imgtec.org>
On 12/07/2015 07:54 PM, Steve Ellcey wrote:
> if (must_annul)
> - used_annul = 1;
> + {
> + /* Frame related instructions cannot go into annulled delay
> + slots, it messes up the dwarf info. */
> + if (RTX_FRAME_RELATED_P (trial))
> + return;
Don't you need to use break rather than return?
> + else if (!RTX_FRAME_RELATED_P (trial) \
Stray backslash.
Other than that I think this is OK. There are some preexisting tests for
frame related insns already in this code.
Bernd
next prev parent reply other threads:[~2015-12-07 19:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 18:54 Steve Ellcey
2015-12-07 19:28 ` Bernd Schmidt [this message]
2015-12-07 19:30 ` Jeff Law
2015-12-07 21:19 ` Steve Ellcey
2015-12-08 22:54 ` Jeff Law
2015-12-07 19:44 ` Steve Ellcey
2015-12-07 19:59 ` Bernd Schmidt
2015-12-07 20:43 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5665DDCB.5070003@redhat.com \
--to=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=sellcey@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).