From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121077 invoked by alias); 8 Dec 2015 10:59:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 121046 invoked by uid 89); 8 Dec 2015 10:59:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Dec 2015 10:58:50 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-28-7kvqU9oyRoiP-oyY_TYLEA-1; Tue, 08 Dec 2015 10:58:44 +0000 Received: from e105915-lin.cambridge.arm.com ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 8 Dec 2015 10:58:42 +0000 Subject: Re: [PATCH] Enable libstdc++ numeric conversions on Cygwin To: Jonathan Wakely , Jennifer Yao References: <20151112114049.GY2937@redhat.com> <20151112133947.GA2937@redhat.com> <20151113145219.GQ2937@redhat.com> Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org, Andreas Tobler From: Alan Lawrence Message-ID: <5666B7E2.6060806@arm.com> Date: Tue, 08 Dec 2015 10:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151113145219.GQ2937@redhat.com> X-MC-Unique: 7kvqU9oyRoiP-oyY_TYLEA-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00843.txt.bz2 On 13/11/15 14:52, Jonathan Wakely wrote: > That patch was wrong, the new macros in include/bits/c++config used > "CSTDIO" instead of "STDIO" so it caused several tests to go from > PASS to UNSUPPORTED, oops! > > This is the correct version, tested again more carefully, on > powerpc64le-linux and powerpc-aix and x86_64-dragonfly. > > Committed to trunk. Just as a note, on baremetal ARM and AArch64 (arm-none-eabi / aarch64-none-= elf),=20 this causes a bunch more tests to be executed that were previously UNSUPPOR= TED,=20 including FAIL: 21_strings/basic_string/numeric_conversions/char/stod.cc execution te= st FAIL: 21_strings/basic_string/numeric_conversions/char/stof.cc execution te= st FAIL: 21_strings/basic_string/numeric_conversions/char/stold.cc execution t= est FAIL: 21_strings/basic_string/numeric_conversions/wchar_t/stod.cc execution= test FAIL: 21_strings/basic_string/numeric_conversions/wchar_t/stof.cc execution= test FAIL: 21_strings/basic_string/numeric_conversions/wchar_t/stold.cc executio= n test FAIL: 27_io/basic_ostream/inserters_arithmetic/char/hexfloat.cc execution t= est these were previously gated off by the dg-require-string-conversions, via t= he=20 "#if !defined(_GLIBCXX_USE_C99) || defined(_GLIBCXX_HAVE_BROKEN_VSWPRINTF)"= as=20 GLIBCXX_USE_C99 was not defined. However, now we have "#if=20 !(_GLIBCXX_USE_C99_STDIO && _GLIBCXX_USE_C99_STDLIB && _GLIBCXX_USE_C99_WCH= AR)"=20 and all of those are true. (Note the tests would have failed before if we had executed them, there is = no=20 change there AFAICS.) Cheers, Alan