[PATCH] Add testcase for c++/68116

[PATCH] Add testcase for c++/68116

[Marek Polacek]

This testcase used to ICE, but compiles fine since the C++ delayed folding
merge.  I'd like to add it to the testsuite and close the PR.

Tested on x86_64-linux, ok for trunk?

2015-12-07  Marek Polacek  <polacek@redhat.com>

	PR c++/68116
	* g++.dg/cpp0x/pr68116.C: New test.

diff --git gcc/testsuite/g++.dg/cpp0x/pr68116.C gcc/testsuite/g++.dg/cpp0x/pr68116.C
index e69de29..04ed901 100644
--- gcc/testsuite/g++.dg/cpp0x/pr68116.C
+++ gcc/testsuite/g++.dg/cpp0x/pr68116.C
@@ -0,0 +1,12 @@
+// PR c++/68116
+// { dg-do compile { target c++11 } }
+
+class C {
+  void foo ();
+  typedef void (C::*T) (int);
+  static T b[];
+};
+C::T C::b[]
+{
+  T (&C::foo)
+};

	Marek

Re: [PATCH] Add testcase for c++/68116

[Bernd Schmidt]

On 12/07/2015 06:49 PM, Marek Polacek wrote:

> diff --git gcc/testsuite/g++.dg/cpp0x/pr68116.C gcc/testsuite/g++.dg/cpp0x/pr68116.C
> index e69de29..04ed901 100644
> --- gcc/testsuite/g++.dg/cpp0x/pr68116.C
> +++ gcc/testsuite/g++.dg/cpp0x/pr68116.C
> @@ -0,0 +1,12 @@
> +// PR c++/68116
> +// { dg-do compile { target c++11 } }
> +
> +class C {
> +  void foo ();
> +  typedef void (C::*T) (int);
> +  static T b[];
> +};
> +C::T C::b[]
> +{
> +  T (&C::foo)
> +};

The problem I have with approving C++ testcases is that I have no idea 
whether this is valid or not or what it expresses. You should Cc Jason 
(which I've now done).


Bernd

Re: [PATCH] Add testcase for c++/68116

[Jason Merrill]

On 12/08/2015 06:54 AM, Bernd Schmidt wrote:
> On 12/07/2015 06:49 PM, Marek Polacek wrote:
>
>> diff --git gcc/testsuite/g++.dg/cpp0x/pr68116.C
>> gcc/testsuite/g++.dg/cpp0x/pr68116.C
>> index e69de29..04ed901 100644
>> --- gcc/testsuite/g++.dg/cpp0x/pr68116.C
>> +++ gcc/testsuite/g++.dg/cpp0x/pr68116.C
>> @@ -0,0 +1,12 @@
>> +// PR c++/68116
>> +// { dg-do compile { target c++11 } }
>> +
>> +class C {
>> +  void foo ();
>> +  typedef void (C::*T) (int);
>> +  static T b[];
>> +};
>> +C::T C::b[]
>> +{
>> +  T (&C::foo)
>> +};
>
> The problem I have with approving C++ testcases is that I have no idea
> whether this is valid or not or what it expresses. You should Cc Jason
> (which I've now done).

That's odd code--I don't approve of the cast in the initializer--but it 
is well-formed.  OK.

Jason

Re: [PATCH] Add testcase for c++/68116

[Marek Polacek]

On Tue, Dec 08, 2015 at 09:15:33AM -0500, Jason Merrill wrote:
> On 12/08/2015 06:54 AM, Bernd Schmidt wrote:
> >On 12/07/2015 06:49 PM, Marek Polacek wrote:
> >
> >>diff --git gcc/testsuite/g++.dg/cpp0x/pr68116.C
> >>gcc/testsuite/g++.dg/cpp0x/pr68116.C
> >>index e69de29..04ed901 100644
> >>--- gcc/testsuite/g++.dg/cpp0x/pr68116.C
> >>+++ gcc/testsuite/g++.dg/cpp0x/pr68116.C
> >>@@ -0,0 +1,12 @@
> >>+// PR c++/68116
> >>+// { dg-do compile { target c++11 } }
> >>+
> >>+class C {
> >>+  void foo ();
> >>+  typedef void (C::*T) (int);
> >>+  static T b[];
> >>+};
> >>+C::T C::b[]
> >>+{
> >>+  T (&C::foo)
> >>+};
> >
> >The problem I have with approving C++ testcases is that I have no idea
> >whether this is valid or not or what it expresses. You should Cc Jason
> >(which I've now done).
> 
> That's odd code--I don't approve of the cast in the initializer--but it is
> well-formed.  OK.

Certainly we shouldn't ICE on this, as we used to, which is what I'm trying to
ensure here.  The code looks weird indeed, but it's C++... ;)

Thanks,

	Marek

Re: [PATCH] Add testcase for c++/68116

[Bernd Schmidt]

On 12/08/2015 03:21 PM, Marek Polacek wrote:
>>>> +C::T C::b[]
>>>> +{
>>>> +  T (&C::foo)
>>>> +};
>>>
>>> The problem I have with approving C++ testcases is that I have no idea
>>> whether this is valid or not or what it expresses. You should Cc Jason
>>> (which I've now done).
>>
>> That's odd code--I don't approve of the cast in the initializer--but it is
>> well-formed.  OK.

For all the other people who were clueless like me, apparently this is a 
thing called "list initialization" or "brace-init" that you can google for.


Bernd