public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernd Schmidt <bschmidt@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] PR c/68757: fix uninitialied src_range for various builtins
Date: Tue, 08 Dec 2015 16:07:00 -0000	[thread overview]
Message-ID: <5667004F.40301@redhat.com> (raw)
In-Reply-To: <1449590536.8490.88.camel@surprise>

On 12/08/2015 05:02 PM, David Malcolm wrote:
>
> I actually implemented something like this when implementing these two
> patches.
>
> Work-in-progress patch attached, which introduces an INVALID_LOCATION
> value for source_location/location_t, and uses it to "poison" the
> initial value of c_expr's src_range, with lots of assertions to verify
> that it's been overwritten by time we use it.
>
> It doesn't fully work yet, but much of gcc.dg survives with this (and
> it's what I used to detect the alignof issue in patch 2).  Does this
> look like something I should pursue?

Most definitely IMO.


Bernd

      reply	other threads:[~2015-12-08 16:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08 15:24 David Malcolm
2015-12-08 15:24 ` [PATCH 2/2] C: fix uninitialized ranges for __alignof__ David Malcolm
2015-12-08 15:38 ` [PATCH 1/2] PR c/68757: fix uninitialied src_range for various builtins Bernd Schmidt
2015-12-08 16:02   ` David Malcolm
2015-12-08 16:07     ` Bernd Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5667004F.40301@redhat.com \
    --to=bschmidt@redhat.com \
    --cc=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).