From: Cesar Philippidis <cesar@codesourcery.com>
To: James Norris <jnorris@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: <fortran@gcc.gnu.org>, Thomas Schwinge <Thomas_Schwinge@mentor.com>
Subject: Re: [gomp4] Fix Fortran deviceptr
Date: Tue, 08 Dec 2015 17:11:00 -0000 [thread overview]
Message-ID: <56670F21.8090802@codesourcery.com> (raw)
In-Reply-To: <566703BC.7030202@codesourcery.com>
On 12/08/2015 08:22 AM, James Norris wrote:
>> 2. It appears that deviceptr code in GOACC_parallel_keyed is mostly
>> identical to GOACC_data_start. Can you put that duplicate code into
>> a function? That would be easier to maintain in the long run.
>>
>
> Fixed.
Where? I don't see a patch.
Since you're working on fortran, can you take a look at how
gfc_match_omp_clauses is handling OMP_CLAUSE_DEVICEPTR. It seems overly
confusing to me. Could it be done in a similar way as OMP_CLAUSE_COPYIN,
i.e., using gfc_match_omp_map_clause?
Cesar
next prev parent reply other threads:[~2015-12-08 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 14:52 James Norris
2015-12-07 15:55 ` Cesar Philippidis
2015-12-08 16:22 ` James Norris
2015-12-08 17:11 ` Cesar Philippidis [this message]
2015-12-09 16:34 ` James Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56670F21.8090802@codesourcery.com \
--to=cesar@codesourcery.com \
--cc=Thomas_Schwinge@mentor.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jnorris@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).