From: Bernd Schmidt <bschmidt@redhat.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [v3] avoid alignment of static variables affecting stack's
Date: Thu, 10 Dec 2015 17:22:00 -0000 [thread overview]
Message-ID: <5669B4D3.3050906@redhat.com> (raw)
In-Reply-To: <5669B16802000078000BE33A@prv-mh.provo.novell.com>
On 12/10/2015 05:07 PM, Jan Beulich wrote:
> If not reaching
>
> if (TREE_CODE (origvar) == SSA_NAME)
> {
> gcc_assert (TREE_CODE (var) != VAR_DECL
> || (!DECL_EXTERNAL (var)
> && !DECL_HAS_VALUE_EXPR_P (var)
> && !TREE_STATIC (var)
> && TREE_TYPE (var) != error_mark_node
> && !DECL_HARD_REGISTER (var)
> && really_expand));
> }
>
> in that case is not a problem, this would make for even simpler a
> change. Please let me know.
I think that's fine. BTW there's a is_global_var predicate that
{c,sh}ould be used for your test.
Bernd
prev parent reply other threads:[~2015-12-10 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 12:38 Jan Beulich
2015-12-10 13:54 ` Bernd Schmidt
2015-12-10 16:08 ` Jan Beulich
2015-12-10 17:22 ` Bernd Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5669B4D3.3050906@redhat.com \
--to=bschmidt@redhat.com \
--cc=JBeulich@suse.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).