From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51157 invoked by alias); 10 Dec 2015 17:22:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 51132 invoked by uid 89); 10 Dec 2015 17:22:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Dec 2015 17:22:30 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 1F2B7537E; Thu, 10 Dec 2015 17:22:29 +0000 (UTC) Received: from localhost.localdomain (vpn1-5-65.ams2.redhat.com [10.36.5.65]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBAHMRKu024004; Thu, 10 Dec 2015 12:22:28 -0500 Subject: Re: [v3] avoid alignment of static variables affecting stack's To: Jan Beulich References: <5669805902000078000BE192@prv-mh.provo.novell.com> <566983F3.5070605@redhat.com> <5669B16802000078000BE33A@prv-mh.provo.novell.com> Cc: gcc-patches@gcc.gnu.org From: Bernd Schmidt Message-ID: <5669B4D3.3050906@redhat.com> Date: Thu, 10 Dec 2015 17:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5669B16802000078000BE33A@prv-mh.provo.novell.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg01167.txt.bz2 On 12/10/2015 05:07 PM, Jan Beulich wrote: > If not reaching > > if (TREE_CODE (origvar) == SSA_NAME) > { > gcc_assert (TREE_CODE (var) != VAR_DECL > || (!DECL_EXTERNAL (var) > && !DECL_HAS_VALUE_EXPR_P (var) > && !TREE_STATIC (var) > && TREE_TYPE (var) != error_mark_node > && !DECL_HARD_REGISTER (var) > && really_expand)); > } > > in that case is not a problem, this would make for even simpler a > change. Please let me know. I think that's fine. BTW there's a is_global_var predicate that {c,sh}ould be used for your test. Bernd