From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60747 invoked by alias); 10 Dec 2015 22:43:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60118 invoked by uid 89); 10 Dec 2015 22:43:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Dec 2015 22:43:29 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 4A5CB8E71F; Thu, 10 Dec 2015 22:43:28 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-32.phx2.redhat.com [10.3.113.32]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBAMhRP3031431; Thu, 10 Dec 2015 17:43:28 -0500 Subject: Re: [PATCH 5/6] [DJGPP] gcc/config/i386: update DJGPP configuration related files To: Andris Pavenis , GCC Patches References: <56631D5D.4030806@wippies.com> From: Jeff Law Message-ID: <566A000F.5090801@redhat.com> Date: Thu, 10 Dec 2015 22:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56631D5D.4030806@wippies.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg01196.txt.bz2 On 12/05/2015 10:22 AM, Andris Pavenis wrote: > Patch include updates to DJGPP related files in gcc/config/i386. > > There are too many changes to gcc/config/i386/djgpp.h and > gcc/config/i386/xm-djgpp.h to list them completely in changelog > entry. > > Andris > > 2015-11-25 Andris Pavenis > > Subject: [PATCH 6/6] [DJGPP] gcc/config/i386: update DJGPP configuration > related files > > * gcc/config/i386/djgpp.h: update > * gcc/config/i386/xm-djgpp.h: update > * gcc/config/i386/djgpp.c: new file > * gcc/config/i386/djgpp.opt: remove obsolete option -mbnu210 > * gcc/config/i386/t-djgpp: new file > * gcc/config.gcc: use i386/t-djgpp for DJGPP target > > 0005-DJGPP-gcc-config-i386-update-DJGPP-configuration-rel.patch > > > From 367432d08b4a00f180c3d0710a0f34cda1b6eeee Mon Sep 17 00:00:00 2001 > From: Andris Pavenis > Date: Sat, 5 Dec 2015 08:49:12 +0200 > Subject: [PATCH 5/6] [DJGPP] gcc/config/i386: update DJGPP configuration related files > > * gcc/config/i386/djgpp.h: update > * gcc/config/i386/xm-djgpp.h: update You should describe what you updated. SImply saying "update" is insufficient here. > diff --git a/gcc/config/i386/djgpp.c b/gcc/config/i386/djgpp.c > new file mode 100644 > index 0000000..29dad33 > --- /dev/null > +++ b/gcc/config/i386/djgpp.c > @@ -0,0 +1,50 @@ > +/* Subroutines for DJGPP. > + Contributed by Andris Pavenis > + Copyright (C) 2013 Free Software Foundation, Inc. Copyright date needs updating. > + > +void > +i386_djgpp_asm_named_section(const char *name, unsigned int flags, > + tree decl) > +{ > + char flagchars[8], *f = flagchars; > + > +(void)decl; /* silence warning. */ The way to do this now is to not give a name to the parameter. So remove "decl" from the function signature (leaving its type though). Then you can remove this line. > --- a/gcc/config/i386/djgpp.h > +++ b/gcc/config/i386/djgpp.h > @@ -17,12 +17,27 @@ You should have received a copy of the GNU General Public License > along with GCC; see the file COPYING3. If not see > . */ > > +#define DBX_DEBUGGING_INFO 1 > +#define SDB_DEBUGGING_INFO 1 ? Really, do you *really* need this. I'd really like to see DBX and SDB debugging info die, not propagate into more targets. > > -#define IX86_MAYBE_NO_LIBGCC_TFMODE > +#undef DBX_REGISTER_NUMBER > +#define DBX_REGISTER_NUMBER(n) svr4_dbx_register_map[n] And if the DBX_DEBUGGING_INFO goes away, can't this go away too? Jeff