public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Fix PR21273
@ 2015-12-11 19:29 Bernd Schmidt
  2015-12-11 19:47 ` Jeff Law
  0 siblings, 1 reply; 2+ messages in thread
From: Bernd Schmidt @ 2015-12-11 19:29 UTC (permalink / raw)
  To: GCC Patches

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

Maybe not the most important PR in the database, but we might as well 
fix and close it. Count the number of alternatives in a MATCH_SCRATCH 
against the max.

Bootstrapped and tested on x86_64-linux (one testcase timed out, almost 
certainly because another test went heavily into swap at one point). Ok?


Bernd


[-- Attachment #2: supscratch.diff --]
[-- Type: text/x-patch, Size: 737 bytes --]

	PR middle-end/21273
	* gensupport.c (collect_insn_data): Look for number of alternatives
	in MATCH_SCRATCH.

Index: gcc/gensupport.c
===================================================================
--- gcc/gensupport.c	(revision 231532)
+++ gcc/gensupport.c	(working copy)
@@ -1068,12 +1068,12 @@ collect_insn_data (rtx pattern, int *pal
   switch (code)
     {
     case MATCH_OPERAND:
-      i = n_alternatives (XSTR (pattern, 2));
+    case MATCH_SCRATCH:
+      i = n_alternatives (XSTR (pattern, code == MATCH_SCRATCH ? 1 : 2));
       *palt = (i > *palt ? i : *palt);
       /* Fall through.  */
 
     case MATCH_OPERATOR:
-    case MATCH_SCRATCH:
     case MATCH_PARALLEL:
       i = XINT (pattern, 0);
       if (i > *pmax)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Fix PR21273
  2015-12-11 19:29 Fix PR21273 Bernd Schmidt
@ 2015-12-11 19:47 ` Jeff Law
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2015-12-11 19:47 UTC (permalink / raw)
  To: Bernd Schmidt, GCC Patches

On 12/11/2015 12:29 PM, Bernd Schmidt wrote:
> Maybe not the most important PR in the database, but we might as well
> fix and close it. Count the number of alternatives in a MATCH_SCRATCH
> against the max.
>
> Bootstrapped and tested on x86_64-linux (one testcase timed out, almost
> certainly because another test went heavily into swap at one point). Ok?
>
>
> Bernd
>
>
> supscratch.diff
>
>
> 	PR middle-end/21273
> 	* gensupport.c (collect_insn_data): Look for number of alternatives
> 	in MATCH_SCRATCH.
OK.  I haven't been watching closely, but you might be in the running 
for oldest bug fixed in the gcc-6 release :-)

Thanks,
Jeff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-11 19:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-11 19:29 Fix PR21273 Bernd Schmidt
2015-12-11 19:47 ` Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).