From: Bernd Schmidt <bschmidt@redhat.com>
To: "Jakub Jelinek" <jakub@redhat.com>,
"Manuel López-Ibáñez" <lopezibanez@gmail.com>,
"Joseph S. Myers" <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix -Werror= handling with aliases (PR c/68833)
Date: Mon, 14 Dec 2015 16:22:00 -0000 [thread overview]
Message-ID: <566EECA0.2010904@redhat.com> (raw)
In-Reply-To: <20151211201807.GK5675@tucnak.redhat.com>
On 12/11/2015 09:18 PM, Jakub Jelinek wrote:
>
> Unfortunately, my patch broke some cases with warning aliases that happened
> to work (by accident) and left some other warning alias cases broken.
>
> This patch attempts to fix that (and add Warning keyword to two warning
> aliases that didn't have it), so that -Werror= works even for them again.
> As we do nothing beyond cancelling -Werror for -Wno-error=, there is no need
> to deal with neg_alias_arg, just alias_arg is enough.
Took me a while to figure out what you were saying with that last
sentence, but in the end I agree.
> 2015-12-11 Jakub Jelinek <jakub@redhat.com>
>
> PR c/68833
> * common.opt (Wmissing-noreturn): Add Warning option.
> * opts-common.c (control_warning_option): If opt is
> alias_target with alias_arg, set arg to it.
>
> * c.opt (Wmissing-format-attribute, Wnormalized): Add Warning option.
>
> * c-c++-common/pr68833-1.c: New test.
> * c-c++-common/pr68833-2.c: New test.
Ok.
Bernd
prev parent reply other threads:[~2015-12-14 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 16:37 [PATCH] Fix -Werror= handling for Joined warnings, add a few missing Warning keywords (PRs c/48088, c/68657) Jakub Jelinek
2015-12-04 17:02 ` Bernd Schmidt
2015-12-04 17:53 ` Jakub Jelinek
2015-12-04 18:20 ` Manuel López-Ibáñez
2015-12-04 19:37 ` Jakub Jelinek
2015-12-07 10:24 ` Bernd Schmidt
2015-12-07 13:45 ` Jakub Jelinek
2015-12-07 15:11 ` Bernd Schmidt
2015-12-07 22:42 ` Jakub Jelinek
2015-12-08 11:56 ` Bernd Schmidt
2015-12-11 20:18 ` [PATCH] Fix -Werror= handling with aliases (PR c/68833) Jakub Jelinek
2015-12-14 16:22 ` Bernd Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566EECA0.2010904@redhat.com \
--to=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=lopezibanez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).