From: Nathan Sidwell <nathan@acm.org>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: update_vtable_references segfault
Date: Wed, 16 Dec 2015 20:16:00 -0000 [thread overview]
Message-ID: <5671C68D.5050504@acm.org> (raw)
In-Reply-To: <566C32D6.90903@acm.org>
On 12/12/15 09:44, Nathan Sidwell wrote:
> On 12/11/15 13:15, Jan Hubicka wrote:
>>> Jan,
>
>>> b) augment can_replace_by_local_alias_in_vtable to check whether
>>> aliases can be created?
>>
>> I think this is best: can_replace_by_local_alias_in_vtable exists to prevent the
>> body walk in cases we are not going to create the alias. This is because in LTO
>> we may need to stream in the constructor from the object file that is not
>> copletely
>> free and thus it is better to not touch it unless necessary.
>
> I went with augmenting can_replace_by_local_alias, which
> can_replace_by_local_alias_in_vtable calls. I also noticed that both should be
> static, which I suspect will encourage the inliner to go inline them and then
> determine a bunch of code is unreachable.
>
> tested on x86-linux and ptx-none.
>
> ok?
https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01324.html
ping?
nathan
next prev parent reply other threads:[~2015-12-16 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 18:04 Nathan Sidwell
2015-12-11 18:15 ` Jan Hubicka
2015-12-12 14:44 ` Nathan Sidwell
2015-12-16 20:16 ` Nathan Sidwell [this message]
2015-12-16 20:54 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5671C68D.5050504@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).