From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128757 invoked by alias); 16 Dec 2015 21:30:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128741 invoked by uid 89); 16 Dec 2015 21:30:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_50,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=PING*5, free_loc_descr, rodat, PierreMarie X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Dec 2015 21:30:18 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 82DC533A888; Wed, 16 Dec 2015 21:30:16 +0000 (UTC) Received: from [10.10.116.46] (ovpn-116-46.rdu2.redhat.com [10.10.116.46]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBGLUFSA013981; Wed, 16 Dec 2015 16:30:15 -0500 Subject: Re: [PATCHES, PING*5] Enhance standard DWARF for Ada To: Pierre-Marie de Rodat , gcc-patches@gcc.gnu.org References: <55A76C7B.7080303@adacore.com> <55B0C74D.3040907@adacore.com> <55BB53F3.1080101@adacore.com> <55BB56B1.8080407@adacore.com> <55C5C54E.8050700@adacore.com> <55E4025B.3050309@adacore.com> <5626A05D.3090905@adacore.com> <564CE0F7.4060801@redhat.com> <56531A3E.40504@adacore.com> <56538037.7060900@redhat.com> <56542B0F.6040102@adacore.com> <5655FF72.7030901@redhat.com> <5656FC6C.7040008@adacore.com> <566B3151.4000209@redhat.com> <56712691.4050709@adacore.com> Cc: Cary Coutant , Eric Botcazou From: Jason Merrill Message-ID: <5671D7E6.6070508@redhat.com> Date: Wed, 16 Dec 2015 21:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56712691.4050709@adacore.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg01663.txt.bz2 On 12/16/2015 03:53 AM, Pierre-Marie de Rodat wrote: > + /* Called from finalize_size_functions for functions whose body is needed to > + generate complete debug info. For instance, functions used to compute the > + size of variable-length structures. */ > + void (* function_body) (tree decl); Calling this "function_body" seems overly generic; let's call it size_function and talk specifically about encoding the function body in the debug info. > debug_nothing_rtx_insn, /* var_location */ > + debug_nothing_tree, /* var_location */ And this comment shouldn't be the same as the previous line. > +/* Helper for loc_descr_without_nops: free the location description operation > + P. */ > +bool > +free_loc_descr (const dw_loc_descr_ref &loc, void *data ATTRIBUTE_UNUSED) Blank line between comment and function. OK with those changes. Jason