mark test requiring pthreads

mark test requiring pthreads

[Nathan Sidwell]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

  c-c++-common/attr-simd-3.c's use of -fcilkplus means it requires pthreads.

nathan
-- 
Nathan Sidwell - Director, Sourcery Services - Mentor Embedded

[-- Attachment #2: trunk-pthread.patch --]
[-- Type: text/x-patch, Size: 654 bytes --]

2015-12-18  Nathan Sidwell  <nathan@acm.org>

	* c-c++-common/attr-simd-3.c: Requires pthreads.

Index: c-c++-common/attr-simd-3.c
===================================================================
--- c-c++-common/attr-simd-3.c	(revision 231815)
+++ c-c++-common/attr-simd-3.c	(working copy)
@@ -1,5 +1,6 @@
 /* { dg-do compile } */
 /* { dg-options "-fcilkplus" } */
 /* { dg-prune-output "undeclared here \\(not in a function\\)|\[^\n\r\]* was not declared in this scope" } */
+/* { dg-require-effective-target pthread } */
 
 void f () __attribute__((__simd__, __vector__)); /* { dg-error "in the same function marked as a Cilk Plus" "PR68158" } */

Re: mark test requiring pthreads

[Rainer Orth]

Hi Nathan,

>  c-c++-common/attr-simd-3.c's use of -fcilkplus means it requires pthreads.

why would this matter for a compile test?  What happens without?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: mark test requiring pthreads

[Nathan Sidwell]

On 12/18/15 09:36, Rainer Orth wrote:
> Hi Nathan,
>
>>   c-c++-common/attr-simd-3.c's use of -fcilkplus means it requires pthreads.
>
> why would this matter for a compile test?  What happens without?

Executing on host: nvptx-none-gcc 
/scratch/nsidwell/openacc/trunk-ptx-shared/src/gcc-mainline/gcc/testsuite/c-c++-common/attr-simd-3.c 
  -fno-diagnostics-show-caret -fdiagnostics-color=never   -Wc++-compat 
-fcilkplus -DSTACK_SIZE=8192 -DNO_TRAMPOLINES -DNO_LABEL_VALUES 
-DSIGNAL_SUPPRESS -S    -o attr-simd-3.s    (timeout = 600)
nvptx-none-gcc: error: unrecognized command line option '-pthread'

compiler exited with status 1
output is:
nvptx-none-gcc: error: unrecognized command line option '-pthread'


FAIL: c-c++-common/attr-simd-3.c  -Wc++-compat  PR68158 (test for errors, line 5)
FAIL: c-c++-common/attr-simd-3.c  -Wc++-compat  (test for excess errors)
Excess errors:
nvptx-none-gcc: error: unrecognized command line option '-pthread'

nathan

Re: mark test requiring pthreads

[Rainer Orth]

Hi Nathan,

> On 12/18/15 09:36, Rainer Orth wrote:
>> Hi Nathan,
>>
>>>   c-c++-common/attr-simd-3.c's use of -fcilkplus means it requires pthreads.
>>
>> why would this matter for a compile test?  What happens without?
>
> Executing on host: nvptx-none-gcc
> /scratch/nsidwell/openacc/trunk-ptx-shared/src/gcc-mainline/gcc/testsuite/c-c++-common/attr-simd-3.c
> -fno-diagnostics-show-caret -fdiagnostics-color=never   -Wc++-compat
> -fcilkplus -DSTACK_SIZE=8192 -DNO_TRAMPOLINES -DNO_LABEL_VALUES
> -DSIGNAL_SUPPRESS -S    -o attr-simd-3.s    (timeout = 600)
> nvptx-none-gcc: error: unrecognized command line option '-pthread'
>
> compiler exited with status 1
> output is:
> nvptx-none-gcc: error: unrecognized command line option '-pthread'
>
>
> FAIL: c-c++-common/attr-simd-3.c -Wc++-compat PR68158 (test for errors,
> line 5)
> FAIL: c-c++-common/attr-simd-3.c  -Wc++-compat  (test for excess errors)
> Excess errors:
> nvptx-none-gcc: error: unrecognized command line option '-pthread'

ok, I see.  I'm uncomfortable declaring the requirement this
indirectly/unobviously.  I'd rather add a requirement on cilkplus (we
have that effective-target keyword already) and update
check_effective_target_cilkplus in target-supports.exp for nvptx.

	Rainer


-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: mark test requiring pthreads

[Jakub Jelinek]

On Fri, Dec 18, 2015 at 03:49:59PM +0100, Rainer Orth wrote:
> Hi Nathan,
> 
> > On 12/18/15 09:36, Rainer Orth wrote:
> >> Hi Nathan,
> >>
> >>>   c-c++-common/attr-simd-3.c's use of -fcilkplus means it requires pthreads.
> >>
> >> why would this matter for a compile test?  What happens without?
> >
> > Executing on host: nvptx-none-gcc
> > /scratch/nsidwell/openacc/trunk-ptx-shared/src/gcc-mainline/gcc/testsuite/c-c++-common/attr-simd-3.c
> > -fno-diagnostics-show-caret -fdiagnostics-color=never   -Wc++-compat
> > -fcilkplus -DSTACK_SIZE=8192 -DNO_TRAMPOLINES -DNO_LABEL_VALUES
> > -DSIGNAL_SUPPRESS -S    -o attr-simd-3.s    (timeout = 600)
> > nvptx-none-gcc: error: unrecognized command line option '-pthread'
> >
> > compiler exited with status 1
> > output is:
> > nvptx-none-gcc: error: unrecognized command line option '-pthread'
> >
> >
> > FAIL: c-c++-common/attr-simd-3.c -Wc++-compat PR68158 (test for errors,
> > line 5)
> > FAIL: c-c++-common/attr-simd-3.c  -Wc++-compat  (test for excess errors)
> > Excess errors:
> > nvptx-none-gcc: error: unrecognized command line option '-pthread'
> 
> ok, I see.  I'm uncomfortable declaring the requirement this
> indirectly/unobviously.  I'd rather add a requirement on cilkplus (we
> have that effective-target keyword already) and update
> check_effective_target_cilkplus in target-supports.exp for nvptx.

That is what we have in the tree until yesterday and it has been very buggy
(disabled all Cilk+ testing on all architectures).
See PR68629 or the gcc-patches discussions about this for details.

	Jakub

Re: mark test requiring pthreads

[Rainer Orth]

Hi Jakub,

>> ok, I see.  I'm uncomfortable declaring the requirement this
>> indirectly/unobviously.  I'd rather add a requirement on cilkplus (we
>> have that effective-target keyword already) and update
>> check_effective_target_cilkplus in target-supports.exp for nvptx.
>
> That is what we have in the tree until yesterday and it has been very buggy
> (disabled all Cilk+ testing on all architectures).
> See PR68629 or the gcc-patches discussions about this for details.

I didn't mean to introduce a compile test like this, but simply return 0
for nvptx-*-* like we already do for avr-*-*.  The compile test is the
correct approach, actually, but would need to be done right...

Besides, doing the -fcilkplus as a link test had been wrong, anyway,
given that many cilkplus tests are compile only...

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: mark test requiring pthreads

[Nathan Sidwell]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On 12/18/15 09:59, Rainer Orth wrote:
> Hi Jakub,
>
>>> ok, I see.  I'm uncomfortable declaring the requirement this
>>> indirectly/unobviously.  I'd rather add a requirement on cilkplus (we
>>> have that effective-target keyword already) and update
>>> check_effective_target_cilkplus in target-supports.exp for nvptx.
>>
>> That is what we have in the tree until yesterday and it has been very buggy
>> (disabled all Cilk+ testing on all architectures).
>> See PR68629 or the gcc-patches discussions about this for details.
>
> I didn't mean to introduce a compile test like this, but simply return 0
> for nvptx-*-* like we already do for avr-*-*.  The compile test is the
> correct approach, actually, but would need to be done right...

committed the attached.


nathan

[-- Attachment #2: trunk-cilk.patch --]
[-- Type: text/x-patch, Size: 1609 bytes --]

2015-12-18  Nathan Sidwell  <nathan@acm.org>

	* lib/target-supports.exp (check_effective_target_cilkplus): Not nvptx.
	* c-c++-common/attr-simd-3.c: Require cilkplus.
	* gcc.dg/graphite/id-28.c: Likewise.

Index: lib/target-supports.exp
===================================================================
--- lib/target-supports.exp	(revision 231818)
+++ lib/target-supports.exp	(working copy)
@@ -1441,6 +1441,12 @@ proc check_effective_target_cilkplus { }
     if { [istarget avr-*-*] } {
 	return 0;
     }
+
+    # No pthreads on NVPTX
+    if { [istarget nvptx-*-*] } {
+	return 0;
+    }
+
     return 1
 }
 
Index: c-c++-common/attr-simd-3.c
===================================================================
--- c-c++-common/attr-simd-3.c	(revision 231818)
+++ c-c++-common/attr-simd-3.c	(working copy)
@@ -1,6 +1,5 @@
-/* { dg-do compile } */
+/* { dg-do compile { target cilkplus } } */
 /* { dg-options "-fcilkplus" } */
 /* { dg-prune-output "undeclared here \\(not in a function\\)|\[^\n\r\]* was not declared in this scope" } */
-/* { dg-require-effective-target pthread } */
 
 void f () __attribute__((__simd__, __vector__)); /* { dg-error "in the same function marked as a Cilk Plus" "PR68158" } */
Index: gcc.dg/graphite/id-28.c
===================================================================
--- gcc.dg/graphite/id-28.c	(revision 231818)
+++ gcc.dg/graphite/id-28.c	(working copy)
@@ -1,5 +1,5 @@
+/* { dg-do compile { target cilkplus } } */
 /* { dg-options "-fcilkplus -floop-nest-optimize -O3" } */
-/* { dg-require-effective-target pthread } */
 
 #if HAVE_IO
 #include <stdio.h>