From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Andrew Pinski <pinskia@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Matthew Wahab <Matthew.Wahab@arm.com>
Subject: Re: [PATCH/AARCH64] Fix -mcpu/arch=native support for LSE
Date: Mon, 21 Dec 2015 13:31:00 -0000 [thread overview]
Message-ID: <5677FF15.3050800@arm.com> (raw)
In-Reply-To: <CA+=Sn1mZmRVLqf_5mHDQZUCX1r0HSiQh=HgLZAHfyXdZ2OBx4w@mail.gmail.com>
On 11/12/15 19:54, Andrew Pinski wrote:
> Hi,
> The Linux kernel calls lse as atomics in /proc/cpuinfo. We should
> change aarch64-option-extensions.def to take that into account.
>
> OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions
> and tested with -mcpu=native on ThunderX T88 pass 2 with Linux 4.4 to
> see if lse gets enabled.
>
> Thanks,
> Andrew Pinski
>
> ChangeLog:
> * config/aarch64/aarch64-option-extensions.def (LSE): Change
> FEAT_STRING to "atomics".
>
Matthew checked in the original patch and he's currently on vacation, so
I can't check why he put 'lse' here. However, I've checked with the
kernel team and they've confirmed that 'atomics' is correct, so OK.
R.
>
> fixlse.diff.txt
>
>
> Index: aarch64-option-extensions.def
> ===================================================================
> --- aarch64-option-extensions.def (revision 231572)
> +++ aarch64-option-extensions.def (working copy)
> @@ -40,4 +40,4 @@ AARCH64_OPT_EXTENSION ("simd", AARCH64_F
> AARCH64_FL_SIMD | AARCH64_FL_CRYPTO, "asimd")
> AARCH64_OPT_EXTENSION("crypto", AARCH64_FL_CRYPTO | AARCH64_FL_FPSIMD, AARCH64_FL_CRYPTO, "aes pmull sha1 sha2")
> AARCH64_OPT_EXTENSION("crc", AARCH64_FL_CRC, AARCH64_FL_CRC, "crc32")
> -AARCH64_OPT_EXTENSION("lse", AARCH64_FL_LSE, AARCH64_FL_LSE, "lse")
> +AARCH64_OPT_EXTENSION("lse", AARCH64_FL_LSE, AARCH64_FL_LSE, "atomics")
>
prev parent reply other threads:[~2015-12-21 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 19:54 Andrew Pinski
2015-12-19 3:57 ` Andrew Pinski
2015-12-21 13:31 ` Richard Earnshaw (lists) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5677FF15.3050800@arm.com \
--to=richard.earnshaw@arm.com \
--cc=Matthew.Wahab@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).