public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Jeff Law <law@redhat.com>,
	James Greenhalgh <james.greenhalgh@arm.com>,
	gcc-patches@gcc.gnu.org
Cc: ramana.radhakrishnan@arm.com
Subject: Re: [Patch testsuite] Skip gcc.dg/ifcvt-4.c for targets on which it may not work
Date: Tue, 22 Dec 2015 11:25:00 -0000	[thread overview]
Message-ID: <56793306.8030505@arm.com> (raw)
In-Reply-To: <56785522.1010108@redhat.com>

On 21/12/15 19:38, Jeff Law wrote:
> On 12/18/2015 02:55 AM, James Greenhalgh wrote:
>> This is a multi-part message in MIME format.
>> --------------2.2.0.1.gd394abb.dirty
>> Content-Type: text/plain; charset=UTF-8; format=fixed
>> Content-Transfer-Encoding: 8bit
>>
>>
>> Hi,
>>
>> PR68232 is a testsuite failure for targets with very low branch costs.
>> As the test is looking for if-conversion, it will fail for any subtarget
>> for which the cost of a branch is sufficiently low that if-conversion
>> looks
>> more expensive.
>>
>> In the current implementation this will be any subtarget with an
>> unpredictable
>>   branch cost of 0 or 1. I had thought this would be very few targets,
>> but
>> at least powerpc64le and arm can trigger this for particular tuning
>> targets.
>>
>> This patch skips the test on those targets.
>>
>> OK?
>>
>> Thanks,
>> James
>>
>> ---
>> 2015-12-17  James Greenhalgh  <james.greenhalgh@arm.com>
>>
>>     PR testsuite/68232
>>     * gcc.dg/ifcvt-4.c: Skip for arm*-*-* and powerpc64le*-*-*.
> OK.
> 
> FWIW, I'd really like to see someone cleanly tweak config-list.mk so
> that we can use it to test this kind of stuff.
> 
> In theory what I want to be able to do is build all the listed targets
> and run a single test on them so that we can build these skip/xfail
> lists much easier.
> 
> I've done it a few times by hand and it seems like it's something we
> ought to be able to do much more easily.
> 
> Jeff
> 

The bigger problem here is that branch costs are a property of a
specific CPU, not the target architecture.  So deciding whether or not
we should skip this test (and perhaps others like it) is impossible
given that we can't know what the default CPU for the compiler is (and
even if we did know, maintaining such a list would be almost impossible).

R.

  reply	other threads:[~2015-12-22 11:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18  9:55 James Greenhalgh
2015-12-21 19:38 ` Jeff Law
2015-12-22 11:25   ` Richard Earnshaw (lists) [this message]
2015-12-22 19:12     ` Jeff Law
2015-12-24 19:40     ` Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56793306.8030505@arm.com \
    --to=richard.earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=james.greenhalgh@arm.com \
    --cc=law@redhat.com \
    --cc=ramana.radhakrishnan@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).