From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119859 invoked by alias); 22 Dec 2015 11:25:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 119844 invoked by uid 89); 22 Dec 2015 11:24:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=maintaining, deciding X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Dec 2015 11:24:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA17A4B6; Tue, 22 Dec 2015 03:24:29 -0800 (PST) Received: from e105689-lin.cambridge.arm.com (e105689-lin.cambridge.arm.com [10.2.207.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 811353F308; Tue, 22 Dec 2015 03:24:55 -0800 (PST) Subject: Re: [Patch testsuite] Skip gcc.dg/ifcvt-4.c for targets on which it may not work To: Jeff Law , James Greenhalgh , gcc-patches@gcc.gnu.org References: <20151218095459.GA18260@arm.com> <56785522.1010108@redhat.com> Cc: ramana.radhakrishnan@arm.com From: "Richard Earnshaw (lists)" X-Enigmail-Draft-Status: N1110 Message-ID: <56793306.8030505@arm.com> Date: Tue, 22 Dec 2015 11:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56785522.1010108@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg02027.txt.bz2 On 21/12/15 19:38, Jeff Law wrote: > On 12/18/2015 02:55 AM, James Greenhalgh wrote: >> This is a multi-part message in MIME format. >> --------------2.2.0.1.gd394abb.dirty >> Content-Type: text/plain; charset=UTF-8; format=fixed >> Content-Transfer-Encoding: 8bit >> >> >> Hi, >> >> PR68232 is a testsuite failure for targets with very low branch costs. >> As the test is looking for if-conversion, it will fail for any subtarget >> for which the cost of a branch is sufficiently low that if-conversion >> looks >> more expensive. >> >> In the current implementation this will be any subtarget with an >> unpredictable >> branch cost of 0 or 1. I had thought this would be very few targets, >> but >> at least powerpc64le and arm can trigger this for particular tuning >> targets. >> >> This patch skips the test on those targets. >> >> OK? >> >> Thanks, >> James >> >> --- >> 2015-12-17 James Greenhalgh >> >> PR testsuite/68232 >> * gcc.dg/ifcvt-4.c: Skip for arm*-*-* and powerpc64le*-*-*. > OK. > > FWIW, I'd really like to see someone cleanly tweak config-list.mk so > that we can use it to test this kind of stuff. > > In theory what I want to be able to do is build all the listed targets > and run a single test on them so that we can build these skip/xfail > lists much easier. > > I've done it a few times by hand and it seems like it's something we > ought to be able to do much more easily. > > Jeff > The bigger problem here is that branch costs are a property of a specific CPU, not the target architecture. So deciding whether or not we should skip this test (and perhaps others like it) is impossible given that we can't know what the default CPU for the compiler is (and even if we did know, maintaining such a list would be almost impossible). R.