Re: [Committed V3 2/2] RISC-V: Move mode assertion out of conditional branch in emit_insn

[Edwin Lu <ewlu@rivosinc.com>]

Thanks!

Edwin

On 6/17/2024 5:33 PM, Jeff Law wrote:
>
>
> On 6/17/24 12:33 PM, Edwin Lu wrote:
>> When emitting insns, we have an early assertion to ensure the input
>> operand's mode and the expanded operand's mode are the same; however, it
>> does not perform this check if the pattern does not have an explicit
>> machine mode specifying the operand. In this scenario, it will always
>> assume that mode = Pmode to correctly satisfy the
>> maybe_legitimize_operand check, however, there may be problems when
>> working in 32 bit environments.
>>
>> Make the assert unconditional and replace it with an internal error for
>> more descriptive logging
>>
>> gcc/ChangeLog:
>>
>>     * config/riscv/riscv-v.cc: Move assert out of conditional block
> OK.
>
> Jeff
>