From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117270 invoked by alias); 2 Jan 2016 05:29:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117260 invoked by uid 89); 2 Jan 2016 05:29:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=nickc@redhat.com, U*nickc, sk:nickc@r, harness X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 02 Jan 2016 05:29:27 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id A8FF58E238 for ; Sat, 2 Jan 2016 05:29:25 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-23.phx2.redhat.com [10.3.113.23]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u025TNsT017401; Sat, 2 Jan 2016 00:29:24 -0500 Subject: Re: RFA: PR 66655: Use COFF/PE weak symbols To: Nick Clifton , gcc-patches@gcc.gnu.org References: <87si2uss7r.fsf@redhat.com> From: Jeff Law Message-ID: <56876033.8010107@redhat.com> Date: Sat, 02 Jan 2016 05:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <87si2uss7r.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00014.txt.bz2 On 12/22/2015 03:17 AM, Nick Clifton wrote: > Hi Guys, > > The patch below is a proposed fix for PR 66655. The issue I believe > is not that the ming32 definition of bind_local_p is wrong, but rather > that G++ thinks that it cannot make the decl weak even though > bind_local_p says that it should. The answer is to define > MAKE_DECL_ONE_ONLY using the COFF/PE weak symbol support now available > in gas and the linker. Doing this allows the test to pass. > > OK to apply ? > > Cheers > Nick > > gcc/ChangeLog > 2015-12-22 Nick Clifton > > PR target/66655 > * config/i386/cygming.h (MAKE_DECL_ONE_ONLY): Use weak symbol > support, if available. You probably know the capabilities of COFF/PE better than I, so the patch itself is fine. Is there any way that test can be shoved into our dejagnu testing harness? I think we've got support somewhere for tests which require multiple input files. Jeff