From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36819 invoked by alias); 5 Jan 2016 10:52:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36806 invoked by uid 89); 5 Jan 2016 10:52:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_20,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Skip, armv4t, pr67989.C, stage3 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Jan 2016 10:52:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E4D049; Tue, 5 Jan 2016 02:52:13 -0800 (PST) Received: from e105689-lin.cambridge.arm.com (e105689-lin.cambridge.arm.com [10.2.207.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D660D3F24D; Tue, 5 Jan 2016 02:52:44 -0800 (PST) Subject: Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu To: Kyrill Tkachov , Thomas Preud'homme , gcc-patches@gcc.gnu.org, Ramana Radhakrishnan References: <11095502.M7ODFCTl7m@hardin.shanghai.arm.com> <568B9F4A.9040506@foss.arm.com> From: "Richard Earnshaw (lists)" Message-ID: <568BA07B.509@arm.com> Date: Tue, 05 Jan 2016 10:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <568B9F4A.9040506@foss.arm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00140.txt.bz2 On 05/01/16 10:47, Kyrill Tkachov wrote: > Hi Thomas, > > On 05/01/16 07:37, Thomas Preud'homme wrote: >> Hi, >> >> g++.dg/pr67989.C passes -march=armv4t to gcc when compiling which >> fails if >> RUNTESTFLAGS passes -mcpu or -march with a different value. This patch >> adds a >> dg-skip-if directive to skip the test when such a thing happens. >> >> ChangeLog entry is as follows: >> >> >> *** gcc/testsuite/ChangeLog *** >> >> 2015-12-31 Thomas Preud'homme >> >> * g++.dg/pr67989.C: Skip test if already running it with >> -mcpu or >> -march with different value. >> >> >> diff --git a/gcc/testsuite/g++.dg/pr67989.C >> b/gcc/testsuite/g++.dg/pr67989.C >> index >> 90261c450b4b9429fb989f7df62f3743017c7363..61be8e172a96df5bb76f7ecd8543dadf825e7dc7 >> >> 100644 >> --- a/gcc/testsuite/g++.dg/pr67989.C >> +++ b/gcc/testsuite/g++.dg/pr67989.C >> @@ -1,5 +1,6 @@ >> /* { dg-do compile } */ >> /* { dg-options "-std=c++11 -O2" } */ >> +/* { dg-skip-if "do not override -mcpu" { arm*-*-* } { "-march=*" >> "-mcpu=*" } >> { "-march=armv4t" } } */ >> /* { dg-additional-options "-marm -march=armv4t" { target arm*-*-* } >> } */ >> > > How about we try to do it using the add_options_for_arm_arch_v4t machinery > and the arm_arch_v4t_ok check? > > I think the -marm part can go and can be added implicitly as part of > multilib testing > Or we could drop all the target-specific options as this is supposed to be a generic test. Yes, I realise this was the particular flag combination required to trigger the original ICE, but no other target running this test has target-specific options, so it seams a little strange that ARM does. R. > Thanks, > Kyrill > > >> __extension__ typedef unsigned long long int uint64_t; >> >> >> Is this ok for stage3? >> >> Best regards, >> >> Thomas >> >