From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31392 invoked by alias); 11 Jan 2016 14:55:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31374 invoked by uid 89); 11 Jan 2016 14:55:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=reminding, horrible, UD:php X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Jan 2016 14:55:27 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1aIdsR-0002pU-OB from Cesar_Philippidis@mentor.com for gcc-patches@gcc.gnu.org; Mon, 11 Jan 2016 06:55:23 -0800 Received: from [IPv6:::1] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.224.2; Mon, 11 Jan 2016 06:55:23 -0800 Subject: Re: [gomp4] private reductions To: Thomas Schwinge , "gcc-patches@gcc.gnu.org" References: <878u6bz9p4.fsf@kepler.schwinge.homeip.net> <568DE196.3040907@codesourcery.com> <87y4bw5nb3.fsf@kepler.schwinge.homeip.net> CC: Nathan Sidwell , james norris From: Cesar Philippidis Message-ID: <5693C25B.10502@codesourcery.com> Date: Mon, 11 Jan 2016 14:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <87y4bw5nb3.fsf@kepler.schwinge.homeip.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00598.txt.bz2 On 01/11/2016 04:10 AM, Thomas Schwinge wrote: > On Wed, 6 Jan 2016 19:55:02 -0800, Cesar Philippidis wrote: >> This patch updates the way that private reductions are handled in gomp4 >> to be more like trunk. > > Anything to commit to trunk (test cases at least?)? I could possibly apply the support nested acc loops using the same reduction variable. But I'd like to hold off a little longer until I have a better solution for reference variables first. >> This patch has been applied to gomp-4_0-branch. > >> PR other/68813 > > Can now close that one? Thanks for reminding me. I closed it. >> --- a/gcc/omp-low.c >> +++ b/gcc/omp-low.c > >> @@ -5731,29 +5624,55 @@ lower_oacc_reductions (location_t loc, tree clauses, tree level, bool inner, > >> - /* This is enabled on trunk, but has been disabled in the merge of >> - trunk r229767 into gomp-4_0-branch, as otherwise there were a >> - lot of regressions in libgomp reduction execution tests. It is >> - unclear if the problem is in the tests themselves, or here, or >> - elsewhere. Given the usage of "var = >> - OMP_CLAUSE_REDUCTION_PRIVATE_DECL (c)" on gomp-4_0-branch, maybe >> - we have to consider that here, too, instead of "orig"? */ >> -#if 0 >> else >> incoming = outgoing = orig; >> -#endif > > Ah, nice -- does your patch completely resolve the issue (that is, remove > the code divergence between trunk and gomp-4_0-branch), that I once asked > Nathan to look into, > ? Yes and no. It's better in the sense that firstprivate and private are now mostly identical with the exception of this change to build_outer_var_ref . Other than that, lower_oacc_reductions in gomp4 has changes for nested reductions. > With you patch applied, I'm seeing some more progressions, so in r232222, > I committed the following to gomp-4_0-branch: Thank you for doing that. I'm horrible at keeping xfails up to date. Cesar