From: Chung-Lin Tang <cltang@codesourcery.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>,
Joseph Myers <joseph@codesourcery.com>
Cc: Sandra Loosemore <sandra@codesourcery.com>,
Jan-Benedict Glaw <jbglaw@lug-owl.de>
Subject: [PATCH] optc-save-gen.awk: adjust generated array compare
Date: Thu, 8 Sep 2022 23:29:12 +0800 [thread overview]
Message-ID: <56951572-c9b4-af2d-0e8b-9d47b87ba313@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]
Hi Joseph,
Jan-Benedict reported a build-bot error for the nios2 port under --enable-werror-always:
options-save.cc: In function 'bool cl_target_option_eq(const cl_target_option*, const cl_target_option*)':
options-save.cc:9291:38: error: comparison between two arrays [-Werror=array-compare]
9291 | if (ptr1->saved_custom_code_status != ptr2->saved_custom_code_status
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
options-save.cc:9291:38: note: use unary '+' which decays operands to pointers or '&'component_ref' not supported by dump_decl<declaration error>[0] != &'component_ref' not supported by dump_decl<declaration error>[0]' to compare the addresses
options-save.cc:9294:37: error: comparison between two arrays [-Werror=array-compare]
9294 | if (ptr1->saved_custom_code_index != ptr2->saved_custom_code_index
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
This is due to an array-typed TargetSave state in config/nios2/nios2.opt:
...
TargetSave
enum nios2_ccs_code saved_custom_code_status[256]
TargetSave
int saved_custom_code_index[256]
...
This patch adjusts the generated array state compare from 'ptr1->array' into '&ptr1->array[0]' in gcc/optc-save-gen.awk,
seems sufficient to pass the tougher checks.
Tested by ensuring the compiler builds, which should be sufficient here.
Okay to commit to mainline?
Thanks,
Chung-Lin
* optc-save-gen.awk: Adjust array compare to use '&ptr->name[0]'
instead of 'ptr->name'.
[-- Attachment #2: a.diff --]
[-- Type: text/plain, Size: 538 bytes --]
diff --git a/gcc/optc-save-gen.awk b/gcc/optc-save-gen.awk
index 233d1fbb637..27aabf2955e 100644
--- a/gcc/optc-save-gen.awk
+++ b/gcc/optc-save-gen.awk
@@ -1093,7 +1093,7 @@ for (i = 0; i < n_target_array; i++) {
name = var_target_array[i]
size = var_target_array_size[i]
type = var_target_array_type[i]
- print " if (ptr1->" name" != ptr2->" name "";
+ print " if (&ptr1->" name"[0] != &ptr2->" name "[0]";
print " || memcmp (ptr1->" name ", ptr2->" name ", " size " * sizeof(" type ")))"
print " return false;";
}
next reply other threads:[~2022-09-08 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 15:29 Chung-Lin Tang [this message]
2022-09-08 16:23 ` Jason Merrill
2022-09-08 18:01 ` Martin Liška
2022-09-08 19:35 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56951572-c9b4-af2d-0e8b-9d47b87ba313@codesourcery.com \
--to=cltang@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jbglaw@lug-owl.de \
--cc=joseph@codesourcery.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).