From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5383 invoked by alias); 12 Jan 2016 15:19:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5362 invoked by uid 89); 12 Jan 2016 15:19:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.7 required=5.0 tests=AWL,BAYES_50,GARBLED_BODY,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=HTo:U*pault, Application, Interface, standards.texi X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Jan 2016 15:19:17 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1aJ0j2-0004fX-6J from James_Norris@mentor.com ; Tue, 12 Jan 2016 07:19:12 -0800 Received: from [172.30.80.87] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.224.2; Tue, 12 Jan 2016 07:19:11 -0800 Subject: Re: [PATCH] OpenACC documentation for libgomp To: Bernd Schmidt , James Norris , GCC Patches , Jakub Jelinek , References: <56716754.1090209@codesourcery.com> <568BE5AF.20109@codesourcery.com> <5693E512.1050406@redhat.com> From: James Norris Message-ID: <5695196B.3080609@codesourcery.com> Date: Tue, 12 Jan 2016 15:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5693E512.1050406@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2016-01/txt/msg00739.txt.bz2 Bernd, On 01/11/2016 11:23 AM, Bernd Schmidt wrote: > On 01/05/2016 04:47 PM, James Norris wrote: >> I've updated the original patch after some very helpful >> comments from Sandra (thank you, thank you). >> >> OK to commit to trunk? > > I'm probably not fully qualified to review the contents either, but few people > are and it looks reasonable enough that I guess I'll just ack it. Before that, > some questions though: > >> +@item @emph{Fortran}: >> +@multitable @columnfractions .20 .80 >> +@item @emph{Prototype}: @tab @code{function acc_async_test(arg);} >> +@item @tab @code{integer(kind=acc_handle_kind) arg} >> +@item @tab @code{logical acc_async_test} >> +@end multitable > > I guess this is how Fortran functions and their args/return values are > documented? Do we have other examples of this somewhere? Yes, in the earlier section that describes OpenMP. One thing that needs changing is 'Prototype' should be changed to 'Interface' for Fortran. >> +about @env{ACC_DEVICE_TYPE} and @env{ACC_DEVICE_NUM} can be found in >> +sections 4.1 and 4.2 of the “The OpenACC >> +Application Programming Interface”, Version 2.0, June, 2013.}. > > Non-ascii characters. I'm guessing this should probably be some kind of texinfo > @something{} block; OTOH references to C standards in standards.texi just name > them in plain text. As Jakub pointed out in followup, those instances should be using a @uref and not double quoted. > > I wonder if things like OpenMP and OpenACC should be mentioned in > standards.texi, but that is tangential to this patch. > That's a good idea. Thanks! Thanks for taking the time for the review. Jim