From: Martin Sebor <msebor@gmail.com>
To: Jason Merrill <jason@redhat.com>,
Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] c++/58109 - alignas() fails to compile with constant expression
Date: Tue, 12 Jan 2016 18:11:00 -0000 [thread overview]
Message-ID: <569541D4.9000307@gmail.com> (raw)
In-Reply-To: <56948D1B.4030403@redhat.com>
On 01/11/2016 10:20 PM, Jason Merrill wrote:
> On 12/22/2015 09:32 PM, Martin Sebor wrote:
>> + if (is_attribute_p ("aligned", name)
>> + || is_attribute_p ("vector_size", name))
>> + {
>> + /* Attribute argument may be a dependent indentifier. */
>> + if (tree t = args ? TREE_VALUE (args) : NULL_TREE)
>> + if (value_dependent_expression_p (t)
>> + || type_dependent_expression_p (t))
>> + return true;
>> + }
>
> Instead of this, is_late_template_attribute should be fixed to check
> attribute_takes_identifier_p.
attribute_takes_identifier_p() returns false for the aligned
attribute and for vector_size (it returns true only for
attributes cleanup, format, and mode, and none others).
Are you suggesting to also change attribute_takes_identifier_p
to return true for these attributes? That would likely mean
changes to the C front end as well.)
Thanks
Martin
next prev parent reply other threads:[~2016-01-12 18:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 2:32 Martin Sebor
2015-12-23 7:53 ` Marc Glisse
2016-01-05 4:49 ` Martin Sebor
2016-01-12 0:46 ` PING #2 " Martin Sebor
2016-01-12 5:20 ` Jason Merrill
2016-01-12 18:11 ` Martin Sebor [this message]
2016-01-15 17:39 ` Martin Sebor
2016-01-18 16:11 ` Jason Merrill
2016-01-20 23:04 ` Martin Sebor
2016-01-22 20:41 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569541D4.9000307@gmail.com \
--to=msebor@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).