From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xry111@xry111.site>
Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1])
 by sourceware.org (Postfix) with ESMTPS id 56965385828E
 for <gcc-patches@gcc.gnu.org>; Tue,  5 Jul 2022 08:47:54 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 56965385828E
Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest
 SHA384) (Client did not present a certificate)
 (Authenticated sender: xry111@xry111.site)
 by xry111.site (Postfix) with ESMTPSA id 33E146679A;
 Tue,  5 Jul 2022 04:47:51 -0400 (EDT)
Message-ID: <5696c3f05f24fe66840630446f54e5c2b4c8eb56.camel@xry111.site>
Subject: Re: [PATCH] Mips: Enable asynchronous unwind tables with both ASAN
 and TSAN
From: Xi Ruoyao <xry111@xry111.site>
To: Fangrui Song <maskray@google.com>
Cc: Dimitrije Milosevic <Dimitrije.Milosevic@syrmia.com>, Djordje Todorovic
 <Djordje.Todorovic@syrmia.com>, "gcc-patches@gcc.gnu.org"
 <gcc-patches@gcc.gnu.org>
Date: Tue, 05 Jul 2022 16:47:49 +0800
In-Reply-To: <624d68f0ea3c05a90e384e7e06a6597ab4158b3a.camel@xry111.site>
References: <AM0PR03MB4882B0699CF9DFC4A63861EB82D99@AM0PR03MB4882.eurprd03.prod.outlook.com>
 <e598dc5e6fb56c31e8ce8ff4569bb3bc64b49dfa.camel@xry111.site>
 <AM0PR03MB48824B387E68EAAEA4938B7E82DD9@AM0PR03MB4882.eurprd03.prod.outlook.com>
 <e3861bbed6d82853bebd60525f57390c5a3e5df3.camel@xry111.site>
 <AM0PR03MB48828EE63C7197F7B70D7F7982A59@AM0PR03MB4882.eurprd03.prod.outlook.com>
 <e6fe20bf45983b25d987dbc38cfc68c71b5181e8.camel@xry111.site>
 <AM0PR03MB48828354AEFA34C729E2756282BE9@AM0PR03MB4882.eurprd03.prod.outlook.com>
 <7e4db89fea59f636afd7abce981cc625d940b5cd.camel@xry111.site>
 <CAFP8O3LjYm+PJviSRkWpHySui8Qkyt9j4Y7uQwvXvY86OSRRaQ@mail.gmail.com>
 <624d68f0ea3c05a90e384e7e06a6597ab4158b3a.camel@xry111.site>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 
MIME-Version: 1.0
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FROM_SUSPICIOUS_NTLD,
 LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP, T_PDS_OTHER_BAD_TLD,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2022 08:47:56 -0000

On Tue, 2022-07-05 at 12:51 +0800, Xi Ruoyao via Gcc-patches wrote:

> I agree it's fine, but the problem is TSAN is currently "unsupported"
> within GCC (i. e. when you build gcc libtsan is not built).=C2=A0 So it
> does
> not make any benefit to commit this change before making TSAN
> supported
> on GCC side.
>=20
> Dimitrije told me TSAN should be supported on 64-bit MIPS, but I can't
> make it work fine with GCC.=C2=A0 I'll need some time to debug...

Hi Fangrui,

On my system dlpi_tls_modid for libtsan.so.2 is 2, instead of 1.=20
GetStaticTlsBoundary seems assuming the dlpi_tls_modid for libtsan.so to
be 1, and returning wrong values if the assumption is broken.

Is it unsafe to make such an assumption?  Or, am I being haunted by a
glibc bug?
--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University