From: Jeff Law <law@redhat.com>
To: Ryan Burn <rnickb731@gmail.com>,
gcc-patches@gcc.gnu.org, Jason Merrill <jason@redhat.com>
Cc: igor.zamyatin@intel.com
Subject: Re: [cilkplus] Fix cilk_spawn gimplification bug (PR cilkplus/69048)
Date: Thu, 14 Jan 2016 21:57:00 -0000 [thread overview]
Message-ID: <569819B2.7050007@redhat.com> (raw)
In-Reply-To: <CACqP_wypCZ_VZZCszN2mEhCgRg=1uXW4-0h7xzmtz6zZC-hR7w@mail.gmail.com>
On 01/14/2016 02:19 PM, Ryan Burn wrote:
> This patch adds a missing cleanup point to cilk_spawn expressions to
> prevent an ICE when calling functions that return types with
> non-trivial destructors.
>
> Bootstrapped and regression tested on x86_64-linux.
>
> 2015-01-14 Ryan Burn <contact@rnburn.com>
>
> PR c++/69048
> * cilk.c (create_cilk_wrapper_body): Call
> fold_build_cleanup_point_expr to add missing cleanup point.
>
> * gcc/testsuite/g++.dg/cilk-plus/CK/pr69048.cc: New test
I thought something was horribly wrong for a few minutes. STMT inside
cilk_create_wrapper_body is a tree, not a gimple statement. So my
worries were unfounded :-)
OK for the trunk.
jeff
next prev parent reply other threads:[~2016-01-14 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 21:19 Ryan Burn
2016-01-14 21:57 ` Jeff Law [this message]
2016-01-14 22:15 ` Ryan Burn
2016-01-14 22:16 ` Jeff Law
2016-01-14 22:34 ` Jakub Jelinek
2016-01-14 22:41 ` Ryan Burn
2016-01-14 22:53 ` Jakub Jelinek
2016-01-14 22:47 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569819B2.7050007@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=igor.zamyatin@intel.com \
--cc=jason@redhat.com \
--cc=rnickb731@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).