Re: genattrab.c generate switch

["Jesper Broge Jørgensen" <jesperbroge@gmail.com>]

On 18/01/16 18:39, Manuel López-Ibáñez wrote:
> On 18/01/16 14:39, Jesper Broge Jørgensen wrote:
>> No i have not gone through copyright assignment.
>> This is my first time trying to contribute to a GNU project so i have 
>> tried
>> following the "Contributing to GCC"@
>> https://gcc.gnu.org/contribute.html
>> There i followed the advice to run the patch through 
>> contrib/check_GNU_style.sh
>> and it came out clean. Maybe contrib/check_GNU_style.sh does not 
>> check for
>> indention rules and/or my editor is set up wrongly so it looked to me 
>> like i
>> was following the coding standard.
>
> Hi Jesper,
>
> Unfortunately, https://gcc.gnu.org/contribute.html is quite hard to 
> follow and outdated. I would suggest to start here: 
> https://gcc.gnu.org/wiki/GettingStarted#Basics:_Contributing_to_GCC_in_10_easy_steps
>
> From there, you'll get to https://gcc.gnu.org/wiki/FormattingCodeForGCC
>
> If you know how to improve those pages, for example extending them to 
> other editors, I can give you write access.
>
> Cheers,
>
> Manuel.
>
Hi

I found a formatting tool called uncrustify that comes with a gnu style 
config 
https://github.com/bengardner/uncrustify/blob/master/etc/gnu-indent.cfg 
that needed a few tweaks to format code that looked what is already in 
gcc/genattrtab.c

The tweaks was:

indent_with_tabs = 2 // instead of 0
sp_func_def_paren     = add // instead of remove
sp_func_proto_paren  = add // instead of remove
sp_func_call_paren     = add // instead of remove

So now the code should be correctly formatted.
Do i send in a new patch or just respond to the old one with the new 
changes?

I have also followed instructions at 
https://gcc.gnu.org/ml/gcc/2003-06/txt00010.txt to get copyright 
assignment though i have not yet received a reply.