From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80472 invoked by alias); 21 Jan 2016 19:58:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 80260 invoked by uid 89); 21 Jan 2016 19:58:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:2355, H*F:D*samsung.com, HContent-transfer-encoding:7bit, ds X-HELO: usmailout3.samsung.com Received: from mailout3.w2.samsung.com (HELO usmailout3.samsung.com) (211.189.100.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 21 Jan 2016 19:58:36 +0000 Received: from uscpsbgm1.samsung.com (u114.gpu85.samsung.co.kr [203.254.195.114]) by usmailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O1B00K6LJHLJL80@usmailout3.samsung.com> for gcc-patches@gcc.gnu.org; Thu, 21 Jan 2016 14:58:34 -0500 (EST) Received: from ussync2.samsung.com ( [203.254.195.82]) by uscpsbgm1.samsung.com (USCPMTA) with SMTP id 40.9F.23844.96831A65; Thu, 21 Jan 2016 14:58:33 -0500 (EST) Received: from [172.31.207.192] ([105.140.31.209]) by ussync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O1B001M9JHKW4B0@ussync2.samsung.com>; Thu, 21 Jan 2016 14:58:33 -0500 (EST) Subject: Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP To: James Greenhalgh References: <568C3D19.908@samsung.com> <568D7CBF.2070407@samsung.com> <20160121092402.GA8842@arm.com> Cc: Wilco Dijkstra , "gcc-patches@gcc.gnu.org" , nd , Andrew Pinski From: Evandro Menezes Message-id: <56A13867.3010103@samsung.com> Date: Thu, 21 Jan 2016 19:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <20160121092402.GA8842@arm.com> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg01669.txt.bz2 Hi, James. On 01/21/16 03:24, James Greenhalgh wrote: > On Wed, Jan 06, 2016 at 02:44:47PM -0600, Evandro Menezes wrote: >> On 01/06/2016 06:04 AM, Wilco Dijkstra wrote: >>>> Here's what I had in mind when I inquired about distinguishing FCMP from >>>> FCCMP. As you can see in the patch, Exynos is the only target that >>>> cares about it, but I wonder if ThunderX or Xgene would too. >>>> >>>> What do you think? >>> The new attributes look fine (I've got a similar outstanding change), however >>> please don't add them to non-AArch64 cores. We only need it for thunderx.md, >>> cortex-a53.md, cortex-a57.md, xgene1.md and exynos-m1.md. >> Add support for the FCCMP insn types >> >> 2016-01-04 Evandro Menezes >> >> gcc/ >> * config/aarch64/aarch64.md (fccmp): Change insn type. >> (fccmpe): Likewise. >> * config/aarch64/thunderx.md (thunderx_fcmp): Add >> "fccmp{s,d}" types. >> * config/arm/cortex-a53.md (cortex_a53_fpalu): Likewise. >> * config/arm/cortex-a57.md (cortex_a57_fp_cmp): Likewise. >> * config/arm/xgene1.md (xgene1_fcmp): Likewise. >> * config/arm/exynos-m1.md (exynos_m1_fp_ccmp): New insn >> reservation. >> * config/arm/types.md (fccmps): Add new insn type. >> (fccmpd): Likewise. >> >> Got it. Here's an updated patch. Again, assuming that your >> original patch is in place. Perhaps you can build on it. > If we don't have any targets which care about the fccmps/fccmpd split in > the code base, do we really need it? Can we just follow the example of > fcsel? The Exynos M1 does care about the difference between FCMP and FCCMP, as can be seen in the patch. >> diff --git a/gcc/config/arm/types.md b/gcc/config/arm/types.md >> index 321ff89..daf7162 100644 >> --- a/gcc/config/arm/types.md >> +++ b/gcc/config/arm/types.md >> @@ -70,6 +70,7 @@ >> ; f_rint[d,s] double/single floating point rount to integral. >> ; f_store[d,s] double/single store to memory. Used for VFP unit. >> ; fadd[d,s] double/single floating-point scalar addition. >> +; fccmp[d,s] double/single floating-point conditional compare. > Can we follow the convention fcsel uses of calling out "From ARMv8-A:" > for this type? > I'm not sure I follow. Though I didn't refer to the ISA spec, I used the description from it for the *fccmp* type. Please, advise. -- Evandro Menezes