From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40175 invoked by alias); 22 Jan 2016 20:41:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40162 invoked by uid 89); 22 Jan 2016 20:41:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1221, late X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 22 Jan 2016 20:41:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id EAA8492472; Fri, 22 Jan 2016 20:41:51 +0000 (UTC) Received: from [10.10.116.23] (ovpn-116-23.rdu2.redhat.com [10.10.116.23]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0MKfp3P006609; Fri, 22 Jan 2016 15:41:51 -0500 Subject: Re: [PATCH] c++/58109 - alignas() fails to compile with constant expression To: Martin Sebor , Gcc Patch List References: <567A07A0.1010008@gmail.com> <56948D1B.4030403@redhat.com> <569541D4.9000307@gmail.com> <569D0EBC.9040809@redhat.com> <56A0127C.6020009@gmail.com> From: Jason Merrill Message-ID: <56A2940F.5080709@redhat.com> Date: Fri, 22 Jan 2016 20:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56A0127C.6020009@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg01789.txt.bz2 On 01/20/2016 06:04 PM, Martin Sebor wrote: >> Right. The problem is this code in is_late_template_attribute: >> >>> /* If the first attribute argument is an identifier, only consider >>> second and following arguments. Attributes like mode, format, >>> cleanup and several target specific attributes aren't late >>> just because they have an IDENTIFIER_NODE as first >>> argument. */ >>> if (arg == args && identifier_p (t)) >>> continue; >> >> It shouldn't skip an initial identifier if !attribute_takes_identifier_p. > > That seems backwards. I expected attribute_takes_identifier_p() > to return true for attribute aligned since the attribute does > take one. There are some attributes (mode, format, cleanup) that have magic handling of identifiers; aligned treats its argument as an expression whether or not that expression takes the form of an identifier. > In any case, I changed the patch as you suggest and retested it > on x86_64. I saw the email about stage 3 having ended but I'm > not sure it applies to changes that are still in progress. I wouldn't think so; certainly not for something this simple. The patch is OK. Jason