From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-420094-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 624 invoked by alias); 26 Jan 2016 19:27:44 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 614 invoked by uid 89); 26 Jan 2016 19:27:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 26 Jan 2016 19:27:42 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id 53176192450;	Tue, 26 Jan 2016 19:27:41 +0000 (UTC)
Received: from [10.10.116.23] (ovpn-116-23.rdu2.redhat.com [10.10.116.23])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0QJReGa012396;	Tue, 26 Jan 2016 14:27:40 -0500
Subject: Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class
To: "H.J. Lu" <hjl.tools@gmail.com>
References: <CAMe9rOo9pcJ_75FmUSs62PBf-neM=+-ftqOD=ffpOm7p6Grx7Q@mail.gmail.com> <CAFiYyc2Qx3DfTraZjUCR0Ha17++SNU-4d5SjGMSWn1hZWKK4uA@mail.gmail.com> <CAMe9rOrMC4XjhFW-a1TdGD2SJo7=yhtGX8r=KxLEyit1WLwpog@mail.gmail.com> <20151209213118.GC317@x4> <CAFiYyc2jYtFdiLRdviOX3M-_BV=h_SnyTMm01jKA4ZAVnbaa6w@mail.gmail.com> <CAMe9rOrogonLyyMwY8BGs-ue52kO8jKiOH9q1KHxWiicWCFHkA@mail.gmail.com> <566C346B.8030601@redhat.com> <20151212152731.GB18720@tucnak.redhat.com> <alpine.DEB.2.20.1512121920570.9203@laptop-mg.saclay.inria.fr> <566F23AE.6070604@redhat.com> <CAMe9rOoodvn=C0NcpHiFb3nVLr2j9vXBibpSpAcE7wKcxSt3jQ@mail.gmail.com> <566F2A0B.4010102@redhat.com> <CAMe9rOpRKYX5csM9PNhO6msWPMe-FAcCcixzEHiGp=WiAN567A@mail.gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>,        Richard Biener <richard.guenther@gmail.com>,        Markus Trippelsdorf <markus@trippelsdorf.de>
From: Jason Merrill <jason@redhat.com>
Message-ID: <56A7C8AC.8070204@redhat.com>
Date: Tue, 26 Jan 2016 19:27:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <CAMe9rOpRKYX5csM9PNhO6msWPMe-FAcCcixzEHiGp=WiAN567A@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-01/txt/msg02024.txt.bz2

On 12/14/2015 05:08 PM, H.J. Lu wrote:
> +  if (abi_version_at_least (10))
> +    TYPE_EMPTY_RECORD (t) = is_really_empty_class (t);

This should use is_empty_class or CLASSTYPE_EMPTY_P.  We don't want to 
change how classes with just a vptr are passed.

Otherwise, it looks OK to me.

Jason