[PATCH] [graphite] document that isl-0.16 is supported

[PATCH] [graphite] document that isl-0.16 is supported

[Sebastian Pop]

	* config/isl.m4: Add comments about isl-0.16.
	* configure: Regenerate.

gcc/
	* doc/install.texi: Document that isl-0.16 is supported.
---
 config/isl.m4        |  6 +++---
 configure            | 12 ++++++------
 gcc/doc/install.texi |  2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/config/isl.m4 b/config/isl.m4
index 0103f1f..92524af 100644
--- a/config/isl.m4
+++ b/config/isl.m4
@@ -106,7 +106,7 @@ AC_DEFUN([ISL_CHECK_VERSION],
     LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs} ${gmplibs}"
     LIBS="${_isl_saved_LIBS} -lisl -lgmp"
 
-    AC_MSG_CHECKING([for isl 0.15 (or deprecated 0.14)])
+    AC_MSG_CHECKING([for isl 0.16, 0.15, or deprecated 0.14])
     AC_TRY_LINK([#include <isl/ctx.h>],
                 [isl_ctx_get_max_operations (isl_ctx_alloc ());],
                 [gcc_cv_isl=yes],
@@ -114,10 +114,10 @@ AC_DEFUN([ISL_CHECK_VERSION],
     AC_MSG_RESULT([$gcc_cv_isl])
 
     if test "${gcc_cv_isl}" = no ; then
-      AC_MSG_RESULT([recommended isl version is 0.15, minimum required isl version 0.14 is deprecated])
+      AC_MSG_RESULT([recommended isl version is 0.16 or 0.15, the minimum required isl version 0.14 is deprecated])
     fi
 
-    AC_MSG_CHECKING([for isl-0.15])
+    AC_MSG_CHECKING([for isl 0.16 or 0.15])
     AC_TRY_LINK([#include <isl/schedule.h>],
                 [isl_options_set_schedule_serialize_sccs (NULL, 0);],
                 [ac_has_isl_options_set_schedule_serialize_sccs=yes],
diff --git a/configure b/configure
index b9a4b51..89c863c 100755
--- a/configure
+++ b/configure
@@ -6021,8 +6021,8 @@ $as_echo "$as_me: WARNING: using in-tree isl, disabling version check" >&2;}
     LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs} ${gmplibs}"
     LIBS="${_isl_saved_LIBS} -lisl -lgmp"
 
-    { $as_echo "$as_me:${as_lineno-$LINENO}: checking for isl 0.15 (or deprecated 0.14)" >&5
-$as_echo_n "checking for isl 0.15 (or deprecated 0.14)... " >&6; }
+    { $as_echo "$as_me:${as_lineno-$LINENO}: checking for isl 0.16, 0.15, or deprecated 0.14" >&5
+$as_echo_n "checking for isl 0.16, 0.15, or deprecated 0.14... " >&6; }
     cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 #include <isl/ctx.h>
@@ -6045,12 +6045,12 @@ rm -f core conftest.err conftest.$ac_objext \
 $as_echo "$gcc_cv_isl" >&6; }
 
     if test "${gcc_cv_isl}" = no ; then
-      { $as_echo "$as_me:${as_lineno-$LINENO}: result: recommended isl version is 0.15, minimum required isl version 0.14 is deprecated" >&5
-$as_echo "recommended isl version is 0.15, minimum required isl version 0.14 is deprecated" >&6; }
+      { $as_echo "$as_me:${as_lineno-$LINENO}: result: recommended isl version is 0.16 or 0.15, the minimum required isl version 0.14 is deprecated" >&5
+$as_echo "recommended isl version is 0.16 or 0.15, the minimum required isl version 0.14 is deprecated" >&6; }
     fi
 
-    { $as_echo "$as_me:${as_lineno-$LINENO}: checking for isl-0.15" >&5
-$as_echo_n "checking for isl-0.15... " >&6; }
+    { $as_echo "$as_me:${as_lineno-$LINENO}: checking for isl 0.16 or 0.15" >&5
+$as_echo_n "checking for isl 0.16 or 0.15... " >&6; }
     cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 #include <isl/schedule.h>
diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
index 062f42c..3df7974 100644
--- a/gcc/doc/install.texi
+++ b/gcc/doc/install.texi
@@ -383,7 +383,7 @@ installed but it is not in your default library search path, the
 @option{--with-mpc} configure option should be used.  See also
 @option{--with-mpc-lib} and @option{--with-mpc-include}.
 
-@item isl Library version 0.15 or 0.14.
+@item isl Library version 0.16, 0.15, or 0.14.
 
 Necessary to build GCC with the Graphite loop optimizations.
 It can be downloaded from @uref{ftp://gcc.gnu.org/pub/gcc/infrastructure/}.
-- 
2.5.0

Re: [PATCH] [graphite] document that isl-0.16 is supported

[Mike Stump]

On Jan 29, 2016, at 8:10 AM, Sebastian Pop <s.pop@samsung.com> wrote:
> diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
> index 062f42c..3df7974 100644
> --- a/gcc/doc/install.texi
> +++ b/gcc/doc/install.texi
> @@ -383,7 +383,7 @@ installed but it is not in your default library search path, the
> @option{--with-mpc} configure option should be used.  See also
> @option{--with-mpc-lib} and @option{--with-mpc-include}.
> 
> -@item isl Library version 0.15 or 0.14.
> +@item isl Library version 0.16, 0.15, or 0.14.

So, they should commit to compatibility with apis vended, and if they do, I think we should say 0.14 or later.  This doesn’t mean that we won’t need fixes from time to time or that they will always do this, but generally that is true.  If we (they) deviate from this, _then_ we document the exceptions.  If release after release goes out, with all newer versions not working, then the list of known good versions is best; but, I’d say that something is terribly broken if we had to do that.

Re: [PATCH] [graphite] document that isl-0.16 is supported

[Sebastian Huber]

On 01/02/16 19:27, Mike Stump wrote:
> On Jan 29, 2016, at 8:10 AM, Sebastian Pop<s.pop@samsung.com>  wrote:
>> >diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
>> >index 062f42c..3df7974 100644
>> >--- a/gcc/doc/install.texi
>> >+++ b/gcc/doc/install.texi
>> >@@ -383,7 +383,7 @@ installed but it is not in your default library search path, the
>> >@option{--with-mpc} configure option should be used.  See also
>> >@option{--with-mpc-lib} and @option{--with-mpc-include}.
>> >
>> >-@item isl Library version 0.15 or 0.14.
>> >+@item isl Library version 0.16, 0.15, or 0.14.
> So, they should commit to compatibility with apis vended, and if they do, I think we should say 0.14 or later.  This doesn’t mean that we won’t need fixes from time to time or that they will always do this, but generally that is true.  If we (they) deviate from this,_then_  we document the exceptions.  If release after release goes out, with all newer versions not working, then the list of known good versions is best; but, I’d say that something is terribly broken if we had to do that.

It would be good to have a recommended version as well (similar for 
cloog, gmp, mpc and mpfr). If you present me three versions which one 
should I choose as a naive user? Are the versions in the 
contrib/download_prerequisites script the recommended ones?

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

Re: [PATCH] [graphite] document that isl-0.16 is supported

[Mike Stump]

On Feb 2, 2016, at 2:23 AM, Sebastian Huber <sebastian.huber@embedded-brains.de> wrote:
> It would be good to have a recommended version as well (similar for cloog, gmp, mpc and mpfr). If you present me three versions which one should I choose as a naive user?

The latest release, or the one on your system.  This is so basic that we expect you to already know this.

> Are the versions in the contrib/download_prerequisites script the recommended ones?

Yes, they are.

Re: [PATCH] [graphite] document that isl-0.16 is supported

[Sebastian Huber]

On 02/02/16 19:00, Mike Stump wrote:
> On Feb 2, 2016, at 2:23 AM, Sebastian Huber<sebastian.huber@embedded-brains.de>  wrote:
>> >It would be good to have a recommended version as well (similar for cloog, gmp, mpc and mpfr). If you present me three versions which one should I choose as a naive user?
> The latest release, or the one on your system.  This is so basic that we expect you to already know this.
>
>> >Are the versions in the contrib/download_prerequisites script the recommended ones?
> Yes, they are.

If it is so basic to choose the latest release or the one on the system, 
then why uses the contrib/download_prerequisites ancient versions, e.g. 
the six year old GMP 4.3.2?

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

Re: [PATCH] [graphite] document that isl-0.16 is supported

[Sebastian Huber]

On 03/02/16 07:29, Sebastian Huber wrote:
>
>
> On 02/02/16 19:00, Mike Stump wrote:
>> On Feb 2, 2016, at 2:23 AM, Sebastian 
>> Huber<sebastian.huber@embedded-brains.de>  wrote:
>>> >It would be good to have a recommended version as well (similar for 
>>> cloog, gmp, mpc and mpfr). If you present me three versions which 
>>> one should I choose as a naive user?
>> The latest release, or the one on your system.  This is so basic that 
>> we expect you to already know this.
>>
>>> >Are the versions in the contrib/download_prerequisites script the 
>>> recommended ones?
>> Yes, they are.
>
> If it is so basic to choose the latest release or the one on the 
> system, then why uses the contrib/download_prerequisites ancient 
> versions, e.g. the six year old GMP 4.3.2?
>

There is exactly one version of GMP, MPC and MPFR available via:

ftp://gcc.gnu.org/pub/gcc/infrastructure/

This doesn't suggest to me that I should use the latest release.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

Re: [PATCH] [graphite] document that isl-0.16 is supported

[Mike Stump]

On Feb 2, 2016, at 10:29 PM, Sebastian Huber <sebastian.huber@embedded-brains.de> wrote:
> If it is so basic to choose the latest release or the one on the system, then why uses the contrib/download_prerequisites ancient versions, e.g. the six year old GMP 4.3.2?

Because no one has seen fit to update it?  I’ll plead ignorance why bumping to the latest release would be bad/wrong.