From: mickael guene <mickael.guene@st.com>
To: Sandra Loosemore <sandra@codesourcery.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PING] Add new mexecute-only arm option.
Date: Wed, 03 Feb 2016 09:23:00 -0000 [thread overview]
Message-ID: <56B1C6E9.9070308@st.com> (raw)
In-Reply-To: <56B10A41.6010503@codesourcery.com>
Hi Sandra,
Thanks for your feedback.
On 02/02/2016 08:57 PM, Sandra Loosemore wrote:
> On 02/02/2016 02:06 AM, mickael guene wrote:
>> Hi All,
>>
>> Ping for following thread :
>>
>> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01968.html
>> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01969.html
>> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01970.html
>
> Two comments:
>
> (1) MIPS has had a similar option for quite some time called
> -mcode-readable=. It might be less confusing to use a similar name for
> the ARM option with the similar reversed sense to -mexecute-only, even
> if it doesn't need to be a tristate flag like for MIPS.
I was unaware of this MIPS option. But anyway I would rather prefer to
stick with -mexecute-only since it's very similar to armcc option naming
for the same feature (--execute_only).
> (2) I suggest changing the help string for the command line option
>
>> +
>> +mexecute-only
>> +Target Report Var(target_execute_only) Init(0)
>> +Forbid load into text sections.
>
> to use the same wording as the documentation in the manual:
>
>> +@item -mexecute-only
>> +@opindex mexecute-only
>> +Disable read memory access inside code sections. Only code fetching is
>> +allowed.
>> +This option is off by default.
>> +
>
> Or at least, "load into text sections" is confusing. (You load *from*
> the text section, not *into* it, right?)
You're right. I will reuse documentation sentence.
Regards
Mickael
prev parent reply other threads:[~2016-02-03 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 9:06 mickael guene
2016-02-02 19:58 ` Sandra Loosemore
2016-02-03 9:23 ` mickael guene [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B1C6E9.9070308@st.com \
--to=mickael.guene@st.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).