[PING] Add new mexecute-only arm option.

[PING] Add new mexecute-only arm option.

[mickael guene]

Hi All,

  Ping for following thread :

https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01968.html
https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01969.html
https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01970.html

Thanks
Mickael

Re: [PING] Add new mexecute-only arm option.

[Sandra Loosemore]

On 02/02/2016 02:06 AM, mickael guene wrote:
> Hi All,
>
>   Ping for following thread :
>
> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01968.html
> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01969.html
> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01970.html

Two comments:

(1) MIPS has had a similar option for quite some time called 
-mcode-readable=.  It might be less confusing to use a similar name for 
the ARM option with the similar reversed sense to -mexecute-only, even 
if it doesn't need to be a tristate flag like for MIPS.

(2) I suggest changing the help string for the command line option

> +
> +mexecute-only
> +Target Report Var(target_execute_only) Init(0)
> +Forbid load into text sections.

to use the same wording as the documentation in the manual:

> +@item -mexecute-only
> +@opindex mexecute-only
> +Disable read memory access inside code sections.  Only code fetching is
> +allowed.
> +This option is off by default.
> +

Or at least, "load into text sections" is confusing.  (You load *from* 
the text section, not *into* it, right?)

-Sandra

Re: [PING] Add new mexecute-only arm option.

[mickael guene]

Hi Sandra,

  Thanks for your feedback.

On 02/02/2016 08:57 PM, Sandra Loosemore wrote:
 > On 02/02/2016 02:06 AM, mickael guene wrote:
 >> Hi All,
 >>
 >>    Ping for following thread :
 >>
 >> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01968.html
 >> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01969.html
 >> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01970.html
 >
 > Two comments:
 >
 > (1) MIPS has had a similar option for quite some time called
 > -mcode-readable=.  It might be less confusing to use a similar name for
 > the ARM option with the similar reversed sense to -mexecute-only, even
 > if it doesn't need to be a tristate flag like for MIPS.
  I was unaware of this MIPS option. But anyway I would rather prefer to
stick with -mexecute-only since it's very similar to armcc option naming
for the same feature (--execute_only).

 > (2) I suggest changing the help string for the command line option
 >
 >> +
 >> +mexecute-only
 >> +Target Report Var(target_execute_only) Init(0)
 >> +Forbid load into text sections.
 >
 > to use the same wording as the documentation in the manual:
 >
 >> +@item -mexecute-only
 >> +@opindex mexecute-only
 >> +Disable read memory access inside code sections.  Only code fetching is
 >> +allowed.
 >> +This option is off by default.
 >> +
 >
 > Or at least, "load into text sections" is confusing.  (You load *from*
 > the text section, not *into* it, right?)

  You're right. I will reuse documentation sentence.

Regards
Mickael