* Re: [PATCH][ARM][1/4] PR target/65932: Add testcase
@ 2016-02-03 8:35 Nick Clifton
2016-02-03 9:46 ` Kyrill Tkachov
0 siblings, 1 reply; 6+ messages in thread
From: Nick Clifton @ 2016-02-03 8:35 UTC (permalink / raw)
To: kyrylo.tkachov; +Cc: gcc-patches
Hi Kyrill,
I would like to approve this patch, but cannot, since it is not ARM
specific. I think that if you ping the list you may be able to get a
response, and it would be nice to see this whole patch series checked
in before the gcc 6 branch occurs.
Cheers
Nick
PS. If necessary you could always move the test to gcc.target/arm...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][ARM][1/4] PR target/65932: Add testcase
2016-02-03 8:35 [PATCH][ARM][1/4] PR target/65932: Add testcase Nick Clifton
@ 2016-02-03 9:46 ` Kyrill Tkachov
2016-02-03 9:51 ` Jakub Jelinek
0 siblings, 1 reply; 6+ messages in thread
From: Kyrill Tkachov @ 2016-02-03 9:46 UTC (permalink / raw)
To: Nick Clifton; +Cc: gcc-patches, 'Jakub Jelinek'
Hi Nick,
On 03/02/16 08:35, Nick Clifton wrote:
> Hi Kyrill,
>
> I would like to approve this patch, but cannot, since it is not ARM
> specific. I think that if you ping the list you may be able to get a
> response, and it would be nice to see this whole patch series checked
> in before the gcc 6 branch occurs.
>
> Cheers
> Nick
>
> PS. If necessary you could always move the test to gcc.target/arm...
>
Thanks again for looking at these.
I'd like to keep this test in the generic directory as we're
trying to avoid cluttering the gcc.target directories with
tests that are not arm-specific.
CC'ing Jakub then. Jakub, is it ok to have the test from
https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01717.html
in gcc.c-torture/execute/ ?
Thanks,
Kyrill
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][ARM][1/4] PR target/65932: Add testcase
2016-02-03 9:46 ` Kyrill Tkachov
@ 2016-02-03 9:51 ` Jakub Jelinek
2016-02-03 10:07 ` Kyrill Tkachov
0 siblings, 1 reply; 6+ messages in thread
From: Jakub Jelinek @ 2016-02-03 9:51 UTC (permalink / raw)
To: Kyrill Tkachov; +Cc: Nick Clifton, gcc-patches
On Wed, Feb 03, 2016 at 09:46:31AM +0000, Kyrill Tkachov wrote:
> Hi Nick,
>
> On 03/02/16 08:35, Nick Clifton wrote:
> >Hi Kyrill,
> >
> > I would like to approve this patch, but cannot, since it is not ARM
> > specific. I think that if you ping the list you may be able to get a
> > response, and it would be nice to see this whole patch series checked
> > in before the gcc 6 branch occurs.
> >
> >Cheers
> > Nick
> >
> >PS. If necessary you could always move the test to gcc.target/arm...
> >
>
> Thanks again for looking at these.
> I'd like to keep this test in the generic directory as we're
> trying to avoid cluttering the gcc.target directories with
> tests that are not arm-specific.
>
> CC'ing Jakub then. Jakub, is it ok to have the test from
> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01717.html
> in gcc.c-torture/execute/ ?
The test is not portable, so not in this form.
Does the test reproduce what you want if you change
0xfffffff1 to -15? If yes, the test is ok with that change.
Jakub
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][ARM][1/4] PR target/65932: Add testcase
2016-02-03 9:51 ` Jakub Jelinek
@ 2016-02-03 10:07 ` Kyrill Tkachov
2016-02-04 9:47 ` Kyrill Tkachov
0 siblings, 1 reply; 6+ messages in thread
From: Kyrill Tkachov @ 2016-02-03 10:07 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Nick Clifton, gcc-patches
On 03/02/16 09:51, Jakub Jelinek wrote:
> On Wed, Feb 03, 2016 at 09:46:31AM +0000, Kyrill Tkachov wrote:
>> Hi Nick,
>>
>> On 03/02/16 08:35, Nick Clifton wrote:
>>> Hi Kyrill,
>>>
>>> I would like to approve this patch, but cannot, since it is not ARM
>>> specific. I think that if you ping the list you may be able to get a
>>> response, and it would be nice to see this whole patch series checked
>>> in before the gcc 6 branch occurs.
>>>
>>> Cheers
>>> Nick
>>>
>>> PS. If necessary you could always move the test to gcc.target/arm...
>>>
>> Thanks again for looking at these.
>> I'd like to keep this test in the generic directory as we're
>> trying to avoid cluttering the gcc.target directories with
>> tests that are not arm-specific.
>>
>> CC'ing Jakub then. Jakub, is it ok to have the test from
>> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01717.html
>> in gcc.c-torture/execute/ ?
> The test is not portable, so not in this form.
> Does the test reproduce what you want if you change
> 0xfffffff1 to -15? If yes, the test is ok with that change.
thanks for spotting this.
Yes, -15 works just as well (bug is reproducible)
I'll make the change.
Kyrill
> Jakub
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][ARM][1/4] PR target/65932: Add testcase
2016-02-03 10:07 ` Kyrill Tkachov
@ 2016-02-04 9:47 ` Kyrill Tkachov
0 siblings, 0 replies; 6+ messages in thread
From: Kyrill Tkachov @ 2016-02-04 9:47 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Nick Clifton, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]
On 03/02/16 10:07, Kyrill Tkachov wrote:
>
> On 03/02/16 09:51, Jakub Jelinek wrote:
>> On Wed, Feb 03, 2016 at 09:46:31AM +0000, Kyrill Tkachov wrote:
>>> Hi Nick,
>>>
>>> On 03/02/16 08:35, Nick Clifton wrote:
>>>> Hi Kyrill,
>>>>
>>>> I would like to approve this patch, but cannot, since it is not ARM
>>>> specific. I think that if you ping the list you may be able to get a
>>>> response, and it would be nice to see this whole patch series checked
>>>> in before the gcc 6 branch occurs.
>>>>
>>>> Cheers
>>>> Nick
>>>>
>>>> PS. If necessary you could always move the test to gcc.target/arm...
>>>>
>>> Thanks again for looking at these.
>>> I'd like to keep this test in the generic directory as we're
>>> trying to avoid cluttering the gcc.target directories with
>>> tests that are not arm-specific.
>>>
>>> CC'ing Jakub then. Jakub, is it ok to have the test from
>>> https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01717.html
>>> in gcc.c-torture/execute/ ?
>> The test is not portable, so not in this form.
>> Does the test reproduce what you want if you change
>> 0xfffffff1 to -15? If yes, the test is ok with that change.
>
> thanks for spotting this.
> Yes, -15 works just as well (bug is reproducible)
> I'll make the change.
>
Here's what I'll be committing shortly when committing the series.
Thanks,
Kyrill
[-- Attachment #2: arm-sign-test.patch --]
[-- Type: text/x-patch, Size: 629 bytes --]
diff --git a/gcc/testsuite/gcc.c-torture/execute/pr67714.c b/gcc/testsuite/gcc.c-torture/execute/pr67714.c
new file mode 100644
index 0000000000000000000000000000000000000000..564c99e16d474019de46125d772b4d611b1adec8
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/execute/pr67714.c
@@ -0,0 +1,26 @@
+unsigned int b;
+int c;
+
+signed char
+fn1 ()
+{
+ signed char d;
+ for (int i = 0; i < 1; i++)
+ d = -15;
+ return d;
+}
+
+int
+main (void)
+{
+ for (c = 0; c < 1; c++)
+ b = 0;
+ char e = fn1 ();
+ signed char f = e ^ b;
+ volatile int g = (int) f;
+
+ if (g != -15)
+ __builtin_abort ();
+
+ return 0;
+}
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH][ARM][1/4] PR target/65932: Add testcase
@ 2016-01-22 9:53 Kyrill Tkachov
0 siblings, 0 replies; 6+ messages in thread
From: Kyrill Tkachov @ 2016-01-22 9:53 UTC (permalink / raw)
To: GCC Patches; +Cc: Ramana Radhakrishnan, Richard Earnshaw, Jim Wilson
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
Hi all,
This patch adds an execute testcase that is fixed by the arm.h hunk of Jim Wilson's
patch that he posted at:
https://gcc.gnu.org/ml/gcc-patches/2015-06/msg02132.html
I propose this testsuite change instead of the testsuite changes in that patch since
the gcc.target/arm/wmul-[123].c regressions are dealt with in the other patches in this series.
Bootstrapped and tested on arm.
Ok for trunk?
Thanks,
Kyrill
2016-01-22 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
PR target/65932
PR target/67714
* gcc.c-torture/execute/pr67714.c: New test.
[-- Attachment #2: arm-promote-mode-test.patch --]
[-- Type: text/x-patch, Size: 636 bytes --]
diff --git a/gcc/testsuite/gcc.c-torture/execute/pr67714.c b/gcc/testsuite/gcc.c-torture/execute/pr67714.c
new file mode 100644
index 0000000000000000000000000000000000000000..386c0dfad8dd786938127d5e45987e7dc113b564
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/execute/pr67714.c
@@ -0,0 +1,26 @@
+unsigned int b;
+int c;
+
+signed char
+fn1 ()
+{
+ signed char d;
+ for (int i = 0; i < 1; i++)
+ d = -15;
+ return d;
+}
+
+int
+main (void)
+{
+ for (c = 0; c < 1; c++)
+ b = 0;
+ char e = fn1 ();
+ signed char f = e ^ b;
+ volatile int g = (int) f;
+
+ if (g != 0xfffffff1)
+ __builtin_abort ();
+
+ return 0;
+}
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-04 9:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-03 8:35 [PATCH][ARM][1/4] PR target/65932: Add testcase Nick Clifton
2016-02-03 9:46 ` Kyrill Tkachov
2016-02-03 9:51 ` Jakub Jelinek
2016-02-03 10:07 ` Kyrill Tkachov
2016-02-04 9:47 ` Kyrill Tkachov
-- strict thread matches above, loose matches on Subject: below --
2016-01-22 9:53 Kyrill Tkachov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).