From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31901 invoked by alias); 6 Feb 2016 23:58:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31883 invoked by uid 89); 6 Feb 2016 23:58:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=dwi X-HELO: mail-pf0-f182.google.com Received: from mail-pf0-f182.google.com (HELO mail-pf0-f182.google.com) (209.85.192.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 06 Feb 2016 23:58:38 +0000 Received: by mail-pf0-f182.google.com with SMTP id w123so89439624pfb.0 for ; Sat, 06 Feb 2016 15:58:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=JGEoN6yBjmn+De/nzmg7ETZjiL9lrHhLa/pimvCkH/E=; b=UYxgMEvdPuB2GvXU65XC4P+tMOja6hHxo0VclbdbJLJn9ynYcZWF/zUHaWybrhRPpe 27Uf7cvsIPnPhWxz7kciTL6S750IjQA1wSuLUXv1kKOZjlErLyALyaoRcPvBV4mGPw0i vUA5JsVQuCbefhYJMbY4p8rcNhUAb+4d/8ZFVuP10zxdt9KyB90JPvgqWS2E6uI2t95p 6zB2TkHgMTMC5DT1im6xjU9PLLpl2Xg725ufAlnrPnLKrcMu/85ZMhzKrkpvG8oSQAEo XfL+EE4n3NFSdpJoTLsrpQ741+OeDjqykr3Hwwob0WE26C0DYm8cCpylS6xGGHVFNX/T Vy0Q== X-Gm-Message-State: AG10YOSu1MFSjUZbf0nzZFzUE0O/Zgsoj3Z+1CZv8xErKbFRRqOFub2bpWzTckWymeMayT71 X-Received: by 10.98.0.7 with SMTP id 7mr31308229pfa.5.1454803116710; Sat, 06 Feb 2016 15:58:36 -0800 (PST) Received: from [192.168.1.9] (ip70-176-202-128.ph.ph.cox.net. [70.176.202.128]) by smtp.googlemail.com with ESMTPSA id 6sm33526050pfo.58.2016.02.06.15.58.35 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 06 Feb 2016 15:58:36 -0800 (PST) Subject: Re: [PATCH, gcc7, aarch64] Add arithmetic overflow patterns To: Richard Henderson , "gcc-patches@gcc.gnu.org" References: <56A9E47D.4030808@linaro.org> <56AA5597.2090600@redhat.com> From: Michael Collison Message-ID: <56B688A6.1020302@linaro.org> Date: Sat, 06 Feb 2016 23:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56AA5597.2090600@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00481.txt.bz2 Richard, One other question on the patch. I note that when you expand the addv and uaddv patterns you emit rtl using gen_add3_compareV and en_add3_compareC respectively. These patterns use sign_extend and zero_extend respectively. Why do you not do the same thing for the subv and usubv patterns? The subv patterns expand into calls to gen_sub3_compare1 which does not emit sign or zero extends. Why the difference? On 01/28/2016 10:53 AM, Richard Henderson wrote: > On 01/28/2016 01:50 AM, Michael Collison wrote: >> Hi Richard, >> >> Note that this patch appears to depend on your previous patch: >> >> https://gcc.gnu.org/ml/gcc-patches/2016-01/txtDPaXOBMuOB.txt >> >> for the definition of define_mode_attr DWI. I was looking at this patch as I >> was working on Bugzilla 68543 which this will address. > Yes, it did. I've now committed a slightly modified patch for pr69305, which > includes some name changes that were present in this patch. There may be minor > patch conflicts but nothing major. > > > > r~ > -- Michael Collison Linaro Toolchain Working Group michael.collison@linaro.org