From: Nathan Sidwell <nathan@acm.org>
To: Cesar Philippidis <cesar@codesourcery.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>,
Nathan Sidwell <nathan_sidwell@mentor.com>
Subject: Re: openacc reference reductions
Date: Tue, 09 Feb 2016 15:33:00 -0000 [thread overview]
Message-ID: <56BA06C3.90606@acm.org> (raw)
In-Reply-To: <56BA0257.6050607@codesourcery.com>
While I've not looked at the rest of the patch, this bit stood out:
> +static bool
> +is_oacc_parallel_reduction (tree var, omp_context *ctx)
> +{
> + if (!is_oacc_parallel (ctx))
> + return false;
> +
> + tree clauses = gimple_omp_target_clauses (ctx->stmt);
> +
> + /* Don't install a local copy of the decl if it used
> + inside a acc parallel reduction. */
^^ comment is misleading -- this routine's not installing anything
> + if (is_oacc_parallel (ctx))
^^ already checked above.
> + for (tree c = clauses; c; c = OMP_CLAUSE_CHAIN (c))
> + if (OMP_CLAUSE_CODE (c) == OMP_CLAUSE_REDUCTION
> + && OMP_CLAUSE_DECL (c) == var)
> + return true;
> +
> + return false;
> +}
> +
next prev parent reply other threads:[~2016-02-09 15:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 15:14 Cesar Philippidis
2016-02-09 15:33 ` Nathan Sidwell [this message]
2016-02-09 16:17 ` Cesar Philippidis
2016-02-22 15:34 ` Cesar Philippidis
2016-02-22 16:23 ` Nathan Sidwell
2016-04-06 1:54 ` Cesar Philippidis
2016-04-06 14:23 ` Jakub Jelinek
2016-04-06 20:21 ` Cesar Philippidis
2016-04-07 9:57 ` Jakub Jelinek
2016-04-08 4:34 ` Cesar Philippidis
2016-04-08 7:41 ` Jakub Jelinek
2016-04-08 7:44 ` Jakub Jelinek
2016-04-08 14:14 ` Nathan Sidwell
2016-04-08 14:21 ` Jakub Jelinek
2016-04-08 14:46 ` Cesar Philippidis
2016-04-08 14:49 ` Nathan Sidwell
2016-04-08 14:35 ` Cesar Philippidis
2016-04-08 15:30 ` Jakub Jelinek
2021-04-26 10:35 ` [OpenACC] Don't compile libgomp testcases with '-w' (was: openacc reference reductions) Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA06C3.90606@acm.org \
--to=nathan@acm.org \
--cc=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=nathan_sidwell@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).