From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76464 invoked by alias); 15 Feb 2016 21:20:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76453 invoked by uid 89); 15 Feb 2016 21:20:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=HContent-transfer-encoding:7bit, Hx-spam-relays-external:ESMTPA, ds X-HELO: usmailout2.samsung.com Received: from mailout2.w2.samsung.com (HELO usmailout2.samsung.com) (211.189.100.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 15 Feb 2016 21:20:06 +0000 Received: from uscpsbgm1.samsung.com (u114.gpu85.samsung.co.kr [203.254.195.114]) by mailout2.w2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O2L00FEHXXGJAD0@mailout2.w2.samsung.com> for gcc-patches@gcc.gnu.org; Mon, 15 Feb 2016 16:20:04 -0500 (EST) Received: from ussync1.samsung.com ( [203.254.195.81]) by uscpsbgm1.samsung.com (USCPMTA) with SMTP id CE.1B.23844.40142C65; Mon, 15 Feb 2016 16:20:04 -0500 (EST) Received: from [172.31.207.192] ([105.140.31.209]) by ussync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O2L00BQ5XXFMN20@ussync1.samsung.com>; Mon, 15 Feb 2016 16:20:04 -0500 (EST) Subject: Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP To: James Greenhalgh References: <568C3D19.908@samsung.com> <568D7CBF.2070407@samsung.com> <20160121092402.GA8842@arm.com> <56A13867.3010103@samsung.com> <20160121220712.GA25892@arm.com> <56A161EC.6070407@samsung.com> <20160215105342.GA20472@arm.com> Cc: Wilco Dijkstra , "gcc-patches@gcc.gnu.org" , nd , Andrew Pinski From: Evandro Menezes Message-id: <56C24102.10601@samsung.com> Date: Mon, 15 Feb 2016 21:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <20160215105342.GA20472@arm.com> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg01021.txt.bz2 On 02/15/16 04:53, James Greenhalgh wrote: > On Thu, Jan 21, 2016 at 04:55:40PM -0600, Evandro Menezes wrote: >> Got it. >> >> Let me try this again: >> >> Add support for the FCCMP insn types >> >> 2016-01-21 Evandro Menezes >> >> gcc/ >> * config/aarch64/aarch64.md (fccmp): Change insn type. >> (fccmpe): Likewise. >> * config/aarch64/thunderx.md (thunderx_fcmp): Add >> "fccmp{s,d}" types. >> * config/arm/cortex-a53.md (cortex_a53_fpalu): Likewise. >> * config/arm/cortex-a57.md (cortex_a57_fp_cmp): Likewise. >> * config/arm/xgene1.md (xgene1_fcmp): Likewise. >> * config/arm/exynos-m1.md (exynos_m1_fp_ccmp): New insn >> reservation. >> * config/arm/types.md (fccmps): Add new insn type. >> (fccmpd): Likewise. >> >> > This is OK. Sorry to have left it waiting so long. > > Thanks, > James > > >> From 14874dec3257c7b59aed4b7c610305f76bbbcf33 Mon Sep 17 00:00:00 2001 >> From: Evandro Menezes >> Date: Mon, 4 Jan 2016 18:44:30 -0600 >> Subject: [PATCH] Add support for the FCCMP insn types >> >> 2016-01-21 Evandro Menezes >> >> gcc/ >> * config/aarch64/aarch64.md (fccmp): Change insn type. >> (fccmpe): Likewise. >> * config/aarch64/thunderx.md (thunderx_fcmp): Add "fccmp{s,d}" types. >> * config/arm/cortex-a53.md (cortex_a53_fpalu): Likewise. >> * config/arm/cortex-a57.md (cortex_a57_fp_cmp): Likewise. >> * config/arm/xgene1.md (xgene1_fcmp): Likewise. >> * config/arm/exynos-m1.md (exynos_m1_fp_ccmp): New insn reservation. >> * config/arm/types.md (fccmps): Add new insn type. >> (fccmpd): Likewise. >> --- >> gcc/config/aarch64/aarch64.md | 4 ++-- >> gcc/config/aarch64/thunderx.md | 2 +- >> gcc/config/arm/cortex-a53.md | 4 ++-- >> gcc/config/arm/cortex-a57.md | 2 +- >> gcc/config/arm/exynos-m1.md | 5 +++++ >> gcc/config/arm/types.md | 3 +++ >> gcc/config/arm/xgene1.md | 2 +- >> 7 files changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md >> index 2f543aa..032b342 100644 >> --- a/gcc/config/aarch64/aarch64.md >> +++ b/gcc/config/aarch64/aarch64.md >> @@ -301,7 +301,7 @@ >> (match_operand 5 "immediate_operand")))] >> "TARGET_FLOAT" >> "fccmp\\t%2, %3, %k5, %m4" >> - [(set_attr "type" "fcmp")] >> + [(set_attr "type" "fccmp")] >> ) >> >> (define_insn "fccmpe" >> @@ -316,7 +316,7 @@ >> (match_operand 5 "immediate_operand")))] >> "TARGET_FLOAT" >> "fccmpe\\t%2, %3, %k5, %m4" >> - [(set_attr "type" "fcmp")] >> + [(set_attr "type" "fccmp")] >> ) >> >> ;; Expansion of signed mod by a power of 2 using CSNEG. >> diff --git a/gcc/config/aarch64/thunderx.md b/gcc/config/aarch64/thunderx.md >> index 922df39..058713a 100644 >> --- a/gcc/config/aarch64/thunderx.md >> +++ b/gcc/config/aarch64/thunderx.md >> @@ -156,7 +156,7 @@ >> >> (define_insn_reservation "thunderx_fcmp" 3 >> (and (eq_attr "tune" "thunderx") >> - (eq_attr "type" "fcmps,fcmpd")) >> + (eq_attr "type" "fcmps,fcmpd,fccmps,fccmpd")) >> "thunderx_pipe1") >> >> (define_insn_reservation "thunderx_fmul" 6 >> diff --git a/gcc/config/arm/cortex-a53.md b/gcc/config/arm/cortex-a53.md >> index c1eeedb..fc60bc2 100644 >> --- a/gcc/config/arm/cortex-a53.md >> +++ b/gcc/config/arm/cortex-a53.md >> @@ -508,8 +508,8 @@ >> (define_insn_reservation "cortex_a53_fpalu" 5 >> (and (eq_attr "tune" "cortexa53") >> (eq_attr "type" "ffariths, fadds, ffarithd, faddd, fmov, >> - f_cvt, fcmps, fcmpd, fcsel, f_rints, f_rintd, >> - f_minmaxs, f_minmaxd")) >> + f_cvt, fcmps, fcmpd, fccmps, fccmpd, fcsel, >> + f_rints, f_rintd, f_minmaxs, f_minmaxd")) >> "cortex_a53_slot_any,cortex_a53_fp_alu") >> >> (define_insn_reservation "cortex_a53_fconst" 3 >> diff --git a/gcc/config/arm/cortex-a57.md b/gcc/config/arm/cortex-a57.md >> index 0d28951..f4c112c 100644 >> --- a/gcc/config/arm/cortex-a57.md >> +++ b/gcc/config/arm/cortex-a57.md >> @@ -716,7 +716,7 @@ >> >> (define_insn_reservation "cortex_a57_fp_cmp" 7 >> (and (eq_attr "tune" "cortexa57") >> - (eq_attr "type" "fcmps,fcmpd")) >> + (eq_attr "type" "fcmps,fcmpd,fccmps,fccmpd")) >> "ca57_cx2") >> >> (define_insn_reservation "cortex_a57_fp_arith" 4 >> diff --git a/gcc/config/arm/exynos-m1.md b/gcc/config/arm/exynos-m1.md >> index 0448073..973c8a9 100644 >> --- a/gcc/config/arm/exynos-m1.md >> +++ b/gcc/config/arm/exynos-m1.md >> @@ -823,6 +823,11 @@ >> (eq_attr "type" "fcmps, fcmpd")) >> "em1_nmisc") >> >> +(define_insn_reservation "exynos_m1_fp_ccmp" 7 >> + (and (eq_attr "tune" "exynosm1") >> + (eq_attr "type" "fccmps, fccmpd")) >> + "em1_st, em1_nmisc") >> + >> (define_insn_reservation "exynos_m1_fp_sel" 4 >> (and (eq_attr "tune" "exynosm1") >> (eq_attr "type" "fcsel")) >> diff --git a/gcc/config/arm/types.md b/gcc/config/arm/types.md >> index 321ff89..25f79b4 100644 >> --- a/gcc/config/arm/types.md >> +++ b/gcc/config/arm/types.md >> @@ -70,6 +70,7 @@ >> ; f_rint[d,s] double/single floating point rount to integral. >> ; f_store[d,s] double/single store to memory. Used for VFP unit. >> ; fadd[d,s] double/single floating-point scalar addition. >> +; fccmp[d,s] From ARMv8-A: floating-point conditional compare. >> ; fcmp[d,s] double/single floating-point compare. >> ; fconst[d,s] double/single load immediate. >> ; fcsel From ARMv8-A: Floating-point conditional select. >> @@ -582,6 +583,8 @@ >> f_stores,\ >> faddd,\ >> fadds,\ >> + fccmpd,\ >> + fccmps,\ >> fcmpd,\ >> fcmps,\ >> fconstd,\ >> diff --git a/gcc/config/arm/xgene1.md b/gcc/config/arm/xgene1.md >> index 8dfd8a1..b7aeac6 100644 >> --- a/gcc/config/arm/xgene1.md >> +++ b/gcc/config/arm/xgene1.md >> @@ -154,7 +154,7 @@ >> >> (define_insn_reservation "xgene1_fcmp" 10 >> (and (eq_attr "tune" "xgene1") >> - (eq_attr "type" "fcmpd,fcmps")) >> + (eq_attr "type" "fcmpd,fcmps,fccmpd,fccmps")) >> "xgene1_decode1op,xgene1_fsu+xgene1_fcmp*3") >> >> (define_insn_reservation "xgene1_fcsel" 3 >> -- >> 2.6.3 >> > > Committed as r233432. Thank you, -- Evandro Menezes