From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85165 invoked by alias); 16 Feb 2016 16:53:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 85146 invoked by uid 89); 16 Feb 2016 16:53:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=201407, Hx-languages-length:1957, HX-detected-operating-system:Windows, cleanly X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 16 Feb 2016 16:53:10 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41395) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1aVis8-00027T-EW for gcc-patches@gnu.org; Tue, 16 Feb 2016 11:53:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVis4-0003XS-ST for gcc-patches@gnu.org; Tue, 16 Feb 2016 11:53:08 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:60665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVis4-0003XG-MD for gcc-patches@gnu.org; Tue, 16 Feb 2016 11:53:04 -0500 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1aVis2-0005XM-EL from Tom_deVries@mentor.com ; Tue, 16 Feb 2016 08:53:02 -0800 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Tue, 16 Feb 2016 16:53:01 +0000 Subject: Re: [PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create To: Jakub Jelinek References: <56B88E34.2050400@mentor.com> <20160208125456.GE3017@tucnak.redhat.com> <56C19C7F.1070202@mentor.com> <20160216022231.GA79627@kam.mff.cuni.cz> <56C2F26A.3060701@mentor.com> <20160216100428.GN3017@tucnak.redhat.com> <56C303A5.5050105@mentor.com> <20160216111143.GQ3017@tucnak.redhat.com> CC: Jan Hubicka , Richard Biener , "gcc-patches@gnu.org" , Ilya Enkovich From: Tom de Vries Message-ID: <56C353E7.1050305@mentor.com> Date: Tue, 16 Feb 2016 16:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160216111143.GQ3017@tucnak.redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 X-SW-Source: 2016-02/txt/msg01091.txt.bz2 On 16/02/16 12:11, Jakub Jelinek wrote: > On Tue, Feb 16, 2016 at 12:10:29PM +0100, Tom de Vries wrote: >> >On 16/02/16 11:04, Jakub Jelinek wrote: >>> > >On Tue, Feb 16, 2016 at 10:56:58AM +0100, Tom de Vries wrote: >>>>> > >>>AFAIU, it's not a release regression given that: >>>>> > >>>- this has failed since 4.9.0, and >>>>> > >>>- the test-case is not supported in 4.8, >>>>> > >>>so we're not required to fix it in 4.9 and 5 branches. >>>>> > >>> >>>>> > >>>But, the test-case does fail in 5 and 4.9 branches, and the fix seems simple >>>>> > >>>enough to not have the risk of introducing breakage in the release branches. >>>>> > >>> >>>>> > >>>OK for 4.9/5 branch? >>> > >Okay. >>> > > >> > >> >Hmm, it doesn't apply cleanly. >> > >> >The trunk version of simd_clone_create also contains: 'Fix ICE for SIMD >> >clones usage in LTO' ( >> >https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00434.html ), which adds the >> >'in_other_partition' propagation in simd_clone_create. >> > >> >That's also not a release regression (reproduces with 4.9.0 release, not >> >supported in 4.8), and still reproduces on 4.9 and 5 branches. >> > >> >OK to backport 'Fix ICE for SIMD clones usage in LTO' to 4.9/5 branch? > Ok. Committed both patches to 4.9 and 5 branches. In order to run testsuite/libgomp.fortran/declare-simd-4.f90 with the 4.9 branch build, I needed in addition: - r212268 https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=212268 https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00218.html - r219606 https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=219606 https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00615.html Should these also be back-ported to 4.9 branch (and in case of r219606, also follow-up fix r219722, https://gcc.gnu.org/viewcvs?rev=219722&root=gcc&view=rev , fix for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64605 )? Thanks, - Tom