From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81477 invoked by alias); 18 Feb 2016 11:01:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 81465 invoked by uid 89); 18 Feb 2016 11:01:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:733, lmx, ftr X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Feb 2016 11:01:57 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1aWMLJ-00060f-Cu from Tom_deVries@mentor.com ; Thu, 18 Feb 2016 03:01:53 -0800 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Thu, 18 Feb 2016 11:01:52 +0000 Subject: Re: [PATCH] Fix driver handling of multiple -ftree-parallelize-loops= options (PR driver/69805) To: Jakub Jelinek , References: <20160216152439.GT3017@tucnak.redhat.com> From: Tom de Vries Message-ID: <56C5A498.7040407@mentor.com> Date: Thu, 18 Feb 2016 11:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160216152439.GT3017@tucnak.redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg01245.txt.bz2 On 16/02/16 16:24, Jakub Jelinek wrote: > Passing the - and ftree-parallelize-loops= stuff looks weird, > and we have %* that substitutes just the variable part of the option, > so in addition to fixing the case of multiple options I've also changed > %:gt() behaviour, so that it now gets just the numbers and compares the > last two of them. FTR, version-compare uses yet another variant: It does not expect to be called with an %{S*} or %{S*:%*} expansion, but passes S as an argument: ... %:version-compare(>= 10.3 mmacosx-version-min= -lmx) ... and the spec function itself takes care of finding the last value. Thanks, - Tom