Revert gcc r227962

Revert gcc r227962

[JonY]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

Hi,

I've submitted a patch that was committed as r227962, it causes some
unintended side effects (namely libuuid on Cygwin). Can someone please
revert?

Kai still needs some time to setup his gcc development environment.

Thanks.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: Revert gcc r227962

[Jeff Law]

On 02/26/2016 04:04 AM, JonY wrote:
> Hi,
>
> I've submitted a patch that was committed as r227962, it causes some
> unintended side effects (namely libuuid on Cygwin). Can someone please
> revert?
>
> Kai still needs some time to setup his gcc development environment.
We'd need to have a better sense of why this is causing problems.  If 
Kai could chime in with a description of the problem it would be helpful.

jeff

Re: Revert gcc r227962

[JonY]

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

On 2/27/2016 05:26, Jeff Law wrote:
> On 02/26/2016 04:04 AM, JonY wrote:
>> Hi,
>>
>> I've submitted a patch that was committed as r227962, it causes some
>> unintended side effects (namely libuuid on Cygwin). Can someone please
>> revert?
>>
>> Kai still needs some time to setup his gcc development environment.
> We'd need to have a better sense of why this is causing problems.  If
> Kai could chime in with a description of the problem it would be helpful.
> 

Normally, /usr/lib is searched BEFORE /usr/lib/w32api. The patch caused
w32api to be searched before /usr/lib.

libuuid.a is known to exist in both directories, with the *nix version
in /usr/lib and the import library for Windows in w32api. The w32api
copy is completely unrelated to the *nix version. This break cygwin apps
that expect to link against *nix libuuid.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: Revert gcc r227962

[Jeff Law]

On 02/27/2016 03:39 AM, JonY wrote:
> On 2/27/2016 05:26, Jeff Law wrote:
>> On 02/26/2016 04:04 AM, JonY wrote:
>>> Hi,
>>>
>>> I've submitted a patch that was committed as r227962, it causes some
>>> unintended side effects (namely libuuid on Cygwin). Can someone please
>>> revert?
>>>
>>> Kai still needs some time to setup his gcc development environment.
>> We'd need to have a better sense of why this is causing problems.  If
>> Kai could chime in with a description of the problem it would be helpful.
>>
>
> Normally, /usr/lib is searched BEFORE /usr/lib/w32api. The patch caused
> w32api to be searched before /usr/lib.
>
> libuuid.a is known to exist in both directories, with the *nix version
> in /usr/lib and the import library for Windows in w32api. The w32api
> copy is completely unrelated to the *nix version. This break cygwin apps
> that expect to link against *nix libuuid.
So if we make this change (revert 227962), my understanding is that 
cygwin bootstraps will fail because they won't find kernel32 and perhaps 
other libraries.

Jeff

Re: Revert gcc r227962

[JonY]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

On 5/20/2016 02:11, Jeff Law wrote:
> So if we make this change (revert 227962), my understanding is that
> cygwin bootstraps will fail because they won't find kernel32 and perhaps
> other libraries.
> 
> Jeff
> 

I'll need to double check with trunk but gcc-5.3.0 built OK without it.
The other alternative is to search /usr/lib before w32api.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: Revert gcc r227962

[JonY]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

On 5/20/2016 06:36, JonY wrote:
> On 5/20/2016 02:11, Jeff Law wrote:
>> So if we make this change (revert 227962), my understanding is that
>> cygwin bootstraps will fail because they won't find kernel32 and perhaps
>> other libraries.
>>
>> Jeff
>>
> 
> I'll need to double check with trunk but gcc-5.3.0 built OK without it.
> The other alternative is to search /usr/lib before w32api.
> 
> 

yep it reached stage 3 but failed from another error building target
libraries (libcilkrts), meaning it was able to find the w32api libraries
even with this patch reverted.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: Revert gcc r227962

[JonY]

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

On 5/23/2016 16:56, JonY wrote:
> On 5/20/2016 06:36, JonY wrote:
>> On 5/20/2016 02:11, Jeff Law wrote:
>>> So if we make this change (revert 227962), my understanding is that
>>> cygwin bootstraps will fail because they won't find kernel32 and perhaps
>>> other libraries.
>>>
>>> Jeff
>>>
>>
>> I'll need to double check with trunk but gcc-5.3.0 built OK without it.
>> The other alternative is to search /usr/lib before w32api.
>>
>>
> 
> yep it reached stage 3 but failed from another error building target
> libraries (libcilkrts), meaning it was able to find the w32api libraries
> even with this patch reverted.
> 

Has it been reverted? I managed to bootstrap after disabling the failing
libraries.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: Revert gcc r227962

[Jeff Law]

On 05/29/2016 08:33 AM, JonY wrote:
> On 5/23/2016 16:56, JonY wrote:
>> On 5/20/2016 06:36, JonY wrote:
>>> On 5/20/2016 02:11, Jeff Law wrote:
>>>> So if we make this change (revert 227962), my understanding is that
>>>> cygwin bootstraps will fail because they won't find kernel32 and perhaps
>>>> other libraries.
>>>>
>>>> Jeff
>>>>
>>>
>>> I'll need to double check with trunk but gcc-5.3.0 built OK without it.
>>> The other alternative is to search /usr/lib before w32api.
>>>
>>>
>>
>> yep it reached stage 3 but failed from another error building target
>> libraries (libcilkrts), meaning it was able to find the w32api libraries
>> even with this patch reverted.
>>
>
> Has it been reverted? I managed to bootstrap after disabling the failing
> libraries.
I've reverted the patch on the trunk.  THanks for your patience.

jeff>