From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-422430-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 35787 invoked by alias); 1 Mar 2016 01:02:06 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 35766 invoked by uid 89); 1 Mar 2016 01:02:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HX-Greylist:Mar, HX-Greylist:Tue
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 01 Mar 2016 01:02:04 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	by mx1.redhat.com (Postfix) with ESMTPS id 36630627CA;	Tue,  1 Mar 2016 01:02:03 +0000 (UTC)
Received: from [10.10.116.22] (ovpn-116-22.rdu2.redhat.com [10.10.116.22])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u21122SK014559;	Mon, 29 Feb 2016 20:02:02 -0500
Subject: Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class
To: "H.J. Lu" <hjl.tools@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org>
References: <CAMe9rOpRKYX5csM9PNhO6msWPMe-FAcCcixzEHiGp=WiAN567A@mail.gmail.com> <56A7C8AC.8070204@redhat.com> <CAMe9rOr96trJpuXrjb_-90SmFmfMCRQ57nyD-4fW7Q5ET_mvFg@mail.gmail.com> <alpine.DEB.2.20.1601262118020.8312@laptop-mg.saclay.inria.fr> <CAMe9rOrXESQ3oJNzvXd1X9k=rD_DM+OSya_54vcRutVVPz4PjA@mail.gmail.com> <alpine.DEB.2.20.1601262134021.8312@laptop-mg.saclay.inria.fr> <CAMe9rOpx=-s-KZzBLWteNeY3JczmJ_p0dKN8giNkWAM92D85Rg@mail.gmail.com> <20160126214000.GL3017@tucnak.redhat.com> <CAMe9rOrFyPmyvnxZtohyC05mXUPPQ6DWk3aCXU8RWts+w9GH+w@mail.gmail.com> <alpine.DEB.2.20.1601270858440.1966@laptop-mg.saclay.inria.fr> <20160127082107.GN3017@tucnak.redhat.com> <alpine.DEB.2.20.1601270953190.1966@laptop-mg.saclay.inria.fr> <CAMe9rOqv4=QiW7USRc4hm=BE47bAX8MfK8J+8827xZkvjM8-VA@mail.gmail.com> <CAMe9rOoRZ0B8mH2yDr+KtoO_PMhUNxTp52D4Ais3vgjNekZWoA@mail.gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>,        Richard Biener <richard.guenther@gmail.com>,        Markus Trippelsdorf <markus@trippelsdorf.de>
From: Jason Merrill <jason@redhat.com>
Message-ID: <56D4EA09.8060505@redhat.com>
Date: Tue, 01 Mar 2016 01:02:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <CAMe9rOoRZ0B8mH2yDr+KtoO_PMhUNxTp52D4Ais3vgjNekZWoA@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-03/txt/msg00002.txt.bz2

On 01/27/2016 10:39 AM, H.J. Lu wrote:
> Here is the updated patch with new testcases.  OK for trunk?

This is not a complete patch.

Please update type_is_empty_record_p to use the definition from the 
recent discussion:

> An empty type is a type where it and all of its subobjects (recursively)
> are of class, structure, union, or array type.

This shouldn't need to rely on the front-end setting a flag.  Be sure to 
ignore unnamed bit-fields, as they are not subobjects.

I would also suggest having this function abort if the type is 
TREE_ADDRESSABLE.

Jason